Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bug) update button fails due to socket-io CORS #163

Open
DamienChing opened this issue Jan 6, 2021 · 0 comments
Open

(bug) update button fails due to socket-io CORS #163

DamienChing opened this issue Jan 6, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@DamienChing
Copy link

DamienChing commented Jan 6, 2021

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Click on 'COMPARE SNAPSHOT'
  2. Click on 'Update Snapshot'

Expected behavior
A clear and concise description of what you expected to happen.

Temp Solution (does not work for firefox)
add "chromeWebSecurity": true to cypress.json

Permanent Solution
you probably want upgrade socket-io and enable cors for all origins.
socket-io <2.4 had this enabled by default, but socket-io 2.2.0 had a bug where this was broken.
socketio/socket.io#3381
image

Screenshots
image
image

Desktop (please complete the following information):

  • OS: OSX Big Sur
  • Cypress Version: 4.5.0+

Additional context
Add any other context about the problem here.

@DamienChing DamienChing added the bug Something isn't working label Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants