Memory Leak of Client Level

[pietro-lopes]

Issue description

This is kinda of a soft leak, as it refreshes itself when you join another world.

Might want to add a cleanup strategy when single players exit world to clear MekanismClient.

Steps to reproduce

1. Join world
2. Leave world
3. Check memory for leaked objects

Minecraft version

1.21.1 (Latest)

NeoForge version

21.1.23

Mekanism version

10.6.7

Other relevant versions

No response

If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)

No response

[thiakil]

this should be fixed with 59645a9

[pietro-lopes]

Does it cover Client player logout?

[thiakil]

It should always have been clearing at that point?

[pietro-lopes]

IIRC, Clone does not trigger at logout.
A good rule of thumb is that at main menu, there should be no client level/player, server, etc. instances alive.

[thiakil]

Indeed it would not fire, but the existing reset method should have been firing is what I meant