Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] remove nodes #168

Open
3 tasks
melMass opened this issue Apr 10, 2024 · 2 comments
Open
3 tasks

[feat] remove nodes #168

melMass opened this issue Apr 10, 2024 · 2 comments

Comments

@melMass
Copy link
Owner

melMass commented Apr 10, 2024

Describe the problem

  • Remove I/O nodes used in VHS, initially forked from mtb it does much more now. (this will cut out A LOT of js code)
  • Image Resizing nodes / Number nodes etc. Most people use essentials anyway
  • FaceSwap / FaceRestore / FILM

Describe the solution you'd like

If not too complex, add a handler script to convert flows using these deleted nodes automatically

Alternatives considered

Deprecate MTB completely

Additional context

No response

@melMass melMass added the type: 🤚 feature request New feature or request label Apr 10, 2024
@melMass
Copy link
Owner Author

melMass commented Jun 9, 2024

  • remove the multi constant attempt, PR on comfy are hard to get merged so I won't have features relying on that from now on. These nodes won't work without the PR and it's currently confusing

comfyanonymous/ComfyUI#3329

@melMass
Copy link
Owner Author

melMass commented Jul 2, 2024

  • Optimize batch from history: I still did not find a better approach to this and I use it all the time but it's clunky and could be optimized:

    • As the history grow the execution slowdown significantly, a solution is to clear the history but that's not ideal.
    • The host IP resolver doesn't always work from remotes.
    • It only support a single OUTPUT_NODE that's probably its biggest limitation currently

    Solutions/Ideas:

    • As for the WIP playlist nodes, it should maybe rely on disk and manage its history, that would allow greater control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant