Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] [comfy_mtb] | ERROR -> guidedFilter not found, use opencv-contrib-python #27

Closed
rethink-studios opened this issue Jul 17, 2023 · 18 comments · Fixed by #22
Closed
Labels
mode: 🎒 comfy-embed Related to the comfy embed mode type: 🐛 bug Something isn't working

Comments

@rethink-studios
Copy link

Describe the bug

Installed the script, and I have missing modules.
How can I fix? (thanks in advance!)

[comfy_mtb] | DEBUG -> Web extensions folder found at D:\ComfyUI\ComfyUI\web\extensions\mtb
[comfy_mtb] | DEBUG -> Imported conditions nodes
[comfy_mtb] | DEBUG -> Imported crop nodes
[comfy_mtb] | DEBUG -> Imported deep_bump nodes
[comfy_mtb] | DEBUG -> Imported graph_utils nodes
[comfy_mtb] | ERROR -> guidedFilter not found, use opencv-contrib-python
[comfy_mtb] | DEBUG -> Imported image_processing nodes
[comfy_mtb] | DEBUG -> Imported latent_processing nodes
[comfy_mtb] | DEBUG -> Imported mask nodes
[comfy_mtb] | DEBUG -> Imported number nodes
[comfy_mtb] | DEBUG -> Imported video nodes
[comfy_mtb] | ERROR -> Some nodes failed to load:
Failed to import faceswap because ModuleNotFoundError: No module named 'ifnude'
Failed to import fun because ModuleNotFoundError: No module named 'qrcode'

Check that you properly installed the dependencies.

Reproduction

Installing on Windows

Expected behavior

Complete installation of dependences

Platform and versions

Windows 11

Console output

D:\ComfyUI>.\python_embeded\python.exe -s ComfyUI\main.py  --preview-method auto --windows-standalone-build
Total VRAM 24564 MB, total RAM 130813 MB
xformers version: 0.0.20
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 4090
Using xformers cross attention
Adding extra search path checkpoints D:/stable-diffusion-webui\models/Stable-diffusion
Adding extra search path configs D:/stable-diffusion-webui\models/Stable-diffusion
Adding extra search path vae D:/stable-diffusion-webui\models/VAE
Adding extra search path loras D:/stable-diffusion-webui\models/Lora
Adding extra search path upscale_models D:/stable-diffusion-webui\models/ESRGAN
Adding extra search path upscale_models D:/stable-diffusion-webui\models/SwinIR
Adding extra search path upscale_models D:/stable-diffusion-webui\models/RealESRGAN
Adding extra search path upscale_models D:/stable-diffusion-webui\models/GFPGAN
Adding extra search path embeddings D:/stable-diffusion-webui\embeddings
Adding extra search path hypernetworks D:/stable-diffusion-webui\models/hypernetworks
Adding extra search path controlnet D:/stable-diffusion-webui\extensions/sd-webui-controlnet/models
Adding extra search path sam D:/stable-diffusion-webui\models/sam
### Loading: ComfyUI-Impact-Pack (V2.21.4)
### Loading: ComfyUI-Manager (V0.11.1)
### ComfyUI Revision: 1156 [b2f03164]
Failed to auto update `Quality of Life Suit`
QualityOfLifeSuit_Omar92_DIR: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-QualityOfLifeSuit_Omar92
### Loading: ComfyUI-Workflow-Component (V0.38.3) !! WARN: This is an experimental extension. Extremely unstable. !!
Comfyroll Custom Nodes: Loaded
Davemane42 Custom Nodes: Loaded
[tinyterraNodes] Loaded
[comfy_mtb] | DEBUG -> Web extensions folder found at D:\ComfyUI\ComfyUI\web\extensions\mtb
[comfy_mtb] | DEBUG -> Imported conditions nodes
[comfy_mtb] | DEBUG -> Imported crop nodes
[comfy_mtb] | DEBUG -> Imported deep_bump nodes
[comfy_mtb] | DEBUG -> Imported graph_utils nodes
[comfy_mtb] | ERROR -> guidedFilter not found, use opencv-contrib-python
[comfy_mtb] | DEBUG -> Imported image_processing nodes
[comfy_mtb] | DEBUG -> Imported latent_processing nodes
[comfy_mtb] | DEBUG -> Imported mask nodes
[comfy_mtb] | DEBUG -> Imported number nodes
[comfy_mtb] | DEBUG -> Imported video nodes
[comfy_mtb] | ERROR -> Some nodes failed to load:
        Failed to import faceswap because ModuleNotFoundError: No module named 'ifnude'
        Failed to import fun because ModuleNotFoundError: No module named 'qrcode'

Check that you properly installed the dependencies.
If you think this is a bug, please report it on the github page (https://github.com/melMass/comfy_mtb/issues)
[comfy_mtb] | DEBUG -> Loaded the following nodes:
        Smart Step (mtb): Utils to control the steps start/stop of the KAdvancedSampler in percentage
        Text To Image (mtb): Utils to convert text to image using a font
        Styles Loader (mtb): Load csv files and populate a dropdown from the rows (à la A111)
        B Box From Mask (mtb): From a mask extract the bounding box
        Bounding Box (mtb): The bounding box (BBOX) custom type used by other nodes
        Crop (mtb): Crops an image and an optional mask to a given bounding box
        Uncrop (mtb): Uncrops an image to a given bounding box
        Deep Bump (mtb): Normal & height maps generation from single pictures
        Save Tensors (mtb): Debug node that will probably be removed in the future
        Color Correct (mtb): Various color correction methods
        Hsv To Rgb (mtb): Convert HSV image to RGB
        Rgb To Hsv (mtb): Convert RGB image to HSV
        Image Compare (mtb): Compare two images and return a difference image
        Denoise (mtb): Denoise an image using total variation minimization.
        Blur (mtb): Blur an image using a Gaussian filter.
        Deglaze Image (mtb): Remove adversarial noise from images
        Mask To Image (mtb): Converts a mask (alpha) to an RGB image with a color and background
        Colored Image (mtb): Constant color image of given size
        Image Premultiply (mtb): Premultiply image with mask
        Image Resize Factor (mtb): Extracted mostly from WAS Node Suite, with a few edits (most notably multiple image support) and less features.
        Save Image Grid (mtb): Save all the images in the input batch as a grid of images.
        Latent Lerp (mtb): Linear interpolation (blend) between two latent vectors
        Image Remove Background Rembg (mtb): -
        Int To Number (mtb): Node addon for the WAS Suite. Converts a "comfy" INT to a NUMBER.
        Load Image Sequence (mtb): Load an image sequence from a folder. The current frame is used to determine which image to load.
        Save Image Sequence (mtb): Save an image sequence to a folder. The current frame is used to determine which image to save.
Total VRAM 24564 MB, total RAM 130813 MB
xformers version: 0.0.20
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 4090
WAS Node Suite: BlenderNeko's Advanced CLIP Text Encode found, attempting to enable `CLIPTextEncode` support.
WAS Node Suite: `CLIPTextEncode (BlenderNeko Advanced + NSP)` node enabled under `WAS Suite/Conditioning` menu.
WAS Node Suite: OpenCV Python FFMPEG support is enabled
WAS Node Suite Warning: `ffmpeg_bin_path` is not set in `D:\ComfyUI\ComfyUI\custom_nodes\was-node-suite-comfyui\was_suite_config.json` config file. Will attempt to use system ffmpeg binaries if available.
WAS Node Suite: Finished. Loaded 186 nodes successfully.

        "Success is not just about making money. It's about making a difference." - Unknown


Import times for custom nodes:
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\sampler_tonemap.py
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\Textnode.py
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\advanced_model_merging.py
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_TiledKSampler
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_ADV_CLIP_emb
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Comfyroll_CustomNodes
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_SeeCoder
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-QualityOfLifeSuit_Omar92
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Custom-Scripts
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\images-grid-comfy-plugin
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\Derfuu_ComfyUI_ModdedNodes
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Dave_CustomNode
   0.1 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-WD14-Tagger
   0.1 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Workflow-Component
   0.1 seconds: D:\ComfyUI\ComfyUI\custom_nodes\comfy_mtb
   0.3 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Manager
   0.5 seconds: D:\ComfyUI\ComfyUI\custom_nodes\clipseg.py
   0.6 seconds: D:\ComfyUI\ComfyUI\custom_nodes\comfy_controlnet_preprocessors
   0.7 seconds: D:\ComfyUI\ComfyUI\custom_nodes\was-node-suite-comfyui
   0.9 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_tinyterraNodes
   1.1 seconds: D:\ComfyUI\ComfyUI\custom_nodes\efficiency-nodes-comfyui
   1.4 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Impact-Pack

Starting server

To see the GUI go to: http://127.0.0.1:8188

Additional context

No response

@rethink-studios rethink-studios added status: 🧹 needs triage This issue needs to triage, applied to new issues type: 🐛 bug Something isn't working labels Jul 17, 2023
@melMass
Copy link
Owner

melMass commented Jul 17, 2023

Hi,

Thanks for the report, the ifnude error should not be anymore but I will check closer right now!

The rest seems all ok, you can safely ignore the opencv mismatch, it's just for one node that I will probably remove in the next release: ImageDeglaze which is based on AdverseCleaner. Basically there are a few flavors of opencv for python, but each are exclusive... WAS Suite for instance installs the headless version of it, this node requires the contrib flavor

@melMass melMass removed the status: 🧹 needs triage This issue needs to triage, applied to new issues label Jul 17, 2023
@melMass
Copy link
Owner

melMass commented Jul 17, 2023

Yep I can confirm that ifnude is not used anymore since this commit: da3e6f4

Maybe try pulling the latest changes: git fetch && git pull from the root directory of the extension

@melMass
Copy link
Owner

melMass commented Jul 17, 2023

A new release is due today, but will more realistically be done tomorrow :)

@rethink-studios
Copy link
Author

rethink-studios commented Jul 17, 2023

Thanks so much for your help!!

I tried git fetch && git pull, and it opened the Connect to Github requestor to sign in via broswer or personal token. Neither has never worked for me, even with the correct info, so I receive this fetch error: fatal: helper error (-1): User cancelled dialog.

In face, none of the custom scripts that use the Connect to Github sign in via browser has worked for me. Is there a way to fix?

From there, I downloaded the latest zip file , overwrote the existing distro, and received a failed to import error. See below:

log
D:\ComfyUI>.\python_embeded\python.exe -s ComfyUI\main.py  --preview-method auto --windows-standalone-build
Total VRAM 24564 MB, total RAM 130813 MB
xformers version: 0.0.20
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 4090
Using xformers cross attention
Adding extra search path checkpoints D:/stable-diffusion-webui\models/Stable-diffusion
Adding extra search path configs D:/stable-diffusion-webui\models/Stable-diffusion
Adding extra search path vae D:/stable-diffusion-webui\models/VAE
Adding extra search path loras D:/stable-diffusion-webui\models/Lora
Adding extra search path upscale_models D:/stable-diffusion-webui\models/ESRGAN
Adding extra search path upscale_models D:/stable-diffusion-webui\models/SwinIR
Adding extra search path upscale_models D:/stable-diffusion-webui\models/RealESRGAN
Adding extra search path upscale_models D:/stable-diffusion-webui\models/GFPGAN
Adding extra search path embeddings D:/stable-diffusion-webui\embeddings
Adding extra search path hypernetworks D:/stable-diffusion-webui\models/hypernetworks
Adding extra search path controlnet D:/stable-diffusion-webui\extensions/sd-webui-controlnet/models
Adding extra search path sam D:/stable-diffusion-webui\models/sam
### Loading: ComfyUI-Impact-Pack (V2.22)
### Loading: ComfyUI-Manager (V0.11.1)
### ComfyUI Revision: 1174 [ee8f8ee0]
Failed to auto update `Quality of Life Suit`
QualityOfLifeSuit_Omar92_DIR: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-QualityOfLifeSuit_Omar92
### Loading: ComfyUI-Workflow-Component (V0.39.5) !! WARN: This is an experimental extension. Extremely unstable. !!
Comfyroll Custom Nodes: Loaded
Davemane42 Custom Nodes: Loaded
[tinyterraNodes] Loaded
Log level: 20
[comfy_mtb] | WARNING -> cv2.ximgproc.guidedFilter not found, use opencv-contrib-python
[comfy_mtb] | ERROR -> Some nodes failed to load:
        Failed to import faceenhance because ModuleNotFoundError: No module named 'gfpgan'
        Failed to import faceswap because ModuleNotFoundError: No module named 'insightface'
        Failed to import fun because ModuleNotFoundError: No module named 'qrcode'
        Failed to import image_interpolation because ModuleNotFoundError: No module named 'frame_interpolation.eval'

Check that you properly installed the dependencies.
If you think this is a bug, please report it on the github page (https://github.com/melMass/comfy_mtb/issues)
[comfy_mtb] | INFO -> Loaded the following nodes:
        Smart Step (mtb): Utils to control the steps start/stop of the KAdvancedSampler in percentage
        Text To Image (mtb): Utils to convert text to image using a font
        Styles Loader (mtb): Load csv files and populate a dropdown from the rows (à la A111)
        B Box From Mask (mtb): From a mask extract the bounding box
        Bounding Box (mtb): The bounding box (BBOX) custom type used by other nodes
        Crop (mtb): Crops an image and an optional mask to a given bounding box
        Uncrop (mtb): Uncrops an image to a given bounding box
        Deep Bump (mtb): Normal & height maps generation from single pictures
        Save Tensors (mtb): Debug node that will probably be removed in the future
        Color Correct (mtb): Various color correction methods
        Hsv To Rgb (mtb): Convert HSV image to RGB
        Rgb To Hsv (mtb): Convert RGB image to HSV
        Image Compare (mtb): Compare two images and return a difference image
        Denoise (mtb): Denoise an image using total variation minimization.
        Blur (mtb): Blur an image using a Gaussian filter.
        Deglaze Image (mtb): Remove adversarial noise from images
        Mask To Image (mtb): Converts a mask (alpha) to an RGB image with a color and background
        Colored Image (mtb): Constant color image of given size
        Image Premultiply (mtb): Premultiply image with mask
        Image Resize Factor (mtb): Extracted mostly from WAS Node Suite, with a few edits (most notably multiple image support) and less features.
        Save Image Grid (mtb): Save all the images in the input batch as a grid of images.
        Latent Lerp (mtb): Linear interpolation (blend) between two latent vectors
        Image Remove Background Rembg (mtb): -
        Int To Number (mtb): Node addon for the WAS Suite. Converts a "comfy" INT to a NUMBER.
        Load Image Sequence (mtb): Load an image sequence from a folder. The current frame is used to determine which image to load.
        Save Image Sequence (mtb): Save an image sequence to a folder. The current frame is used to determine which image to save.
Total VRAM 24564 MB, total RAM 130813 MB
xformers version: 0.0.20
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 4090
WAS Node Suite: BlenderNeko's Advanced CLIP Text Encode found, attempting to enable `CLIPTextEncode` support.
WAS Node Suite: `CLIPTextEncode (BlenderNeko Advanced + NSP)` node enabled under `WAS Suite/Conditioning` menu.
WAS Node Suite: OpenCV Python FFMPEG support is enabled
WAS Node Suite Warning: `ffmpeg_bin_path` is not set in `D:\ComfyUI\ComfyUI\custom_nodes\was-node-suite-comfyui\was_suite_config.json` config file. Will attempt to use system ffmpeg binaries if available.
WAS Node Suite: Finished. Loaded 186 nodes successfully.

        "Success is not just about making money. It's about making a difference." - Unknown


Import times for custom nodes:
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\sampler_tonemap.py
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\sampler_rescalecfg.py
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\Textnode.py
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\advanced_model_merging.py
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_TiledKSampler
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_ADV_CLIP_emb
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Comfyroll_CustomNodes
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_SeeCoder
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Dave_CustomNode
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Custom-Scripts
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-QualityOfLifeSuit_Omar92
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\images-grid-comfy-plugin
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\Derfuu_ComfyUI_ModdedNodes
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Workflow-Component
   0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-WD14-Tagger
   0.1 seconds: D:\ComfyUI\ComfyUI\custom_nodes\comfy_mtb
   0.2 seconds: D:\ComfyUI\ComfyUI\custom_nodes\clipseg.py
   0.2 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Manager
   0.3 seconds: D:\ComfyUI\ComfyUI\custom_nodes\comfy_controlnet_preprocessors
   0.4 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_tinyterraNodes
   0.4 seconds: D:\ComfyUI\ComfyUI\custom_nodes\efficiency-nodes-comfyui
   0.6 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Impact-Pack
   0.7 seconds: D:\ComfyUI\ComfyUI\custom_nodes\was-node-suite-comfyui

Starting server

To see the GUI go to: http://127.0.0.1:8188

@melMass
Copy link
Owner

melMass commented Jul 17, 2023

Thanks for the details, yes the zip from github don't include the submodules unfortunately (dear-github/dear-github#214), my release script does bundle them into the zip file though so by tomorrow I should release 0.1.0.

If you want to try manually you can just unzip these into the extern folder:

  • gpfgan.zip - This is used for face restoration
  • FILM.zip - This is used for the frame interpolation nodes.

Note that even if some node fails the others don't.

@melMass melMass modified the milestone: Release of v0.1.0 Jul 17, 2023
@melMass melMass linked a pull request Jul 17, 2023 that will close this issue
5 tasks
@rethink-studios
Copy link
Author

Downloaded the two files and placed them in the "extern" folder: Log below:

D:\ComfyUI>.\python_embeded\python.exe -s ComfyUI\main.py --preview-method auto --windows-standalone-build
Total VRAM 24564 MB, total RAM 130813 MB
xformers version: 0.0.20
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 4090
Using xformers cross attention
Adding extra search path checkpoints D:/stable-diffusion-webui\models/Stable-diffusion
Adding extra search path configs D:/stable-diffusion-webui\models/Stable-diffusion
Adding extra search path vae D:/stable-diffusion-webui\models/VAE
Adding extra search path loras D:/stable-diffusion-webui\models/Lora
Adding extra search path upscale_models D:/stable-diffusion-webui\models/ESRGAN
Adding extra search path upscale_models D:/stable-diffusion-webui\models/SwinIR
Adding extra search path upscale_models D:/stable-diffusion-webui\models/RealESRGAN
Adding extra search path upscale_models D:/stable-diffusion-webui\models/GFPGAN
Adding extra search path embeddings D:/stable-diffusion-webui\embeddings
Adding extra search path hypernetworks D:/stable-diffusion-webui\models/hypernetworks
Adding extra search path controlnet D:/stable-diffusion-webui\extensions/sd-webui-controlnet/models
Adding extra search path sam D:/stable-diffusion-webui\models/sam

Loading: ComfyUI-Impact-Pack (V2.22)

Loading: ComfyUI-Manager (V0.11.1)

ComfyUI Revision: 1174 [ee8f8ee0]

Failed to auto update Quality of Life Suit
QualityOfLifeSuit_Omar92_DIR: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-QualityOfLifeSuit_Omar92

Loading: ComfyUI-Workflow-Component (V0.39.5) !! WARN: This is an experimental extension. Extremely unstable. !!

Comfyroll Custom Nodes: Loaded
Davemane42 Custom Nodes: Loaded
[tinyterraNodes] Loaded
Log level: 20
[comfy_mtb] | WARNING -> cv2.ximgproc.guidedFilter not found, use opencv-contrib-python
[comfy_mtb] | ERROR -> Some nodes failed to load:
Failed to import faceenhance because ModuleNotFoundError: No module named 'basicsr'
Failed to import faceswap because ModuleNotFoundError: No module named 'insightface'
Failed to import fun because ModuleNotFoundError: No module named 'qrcode'
Failed to import image_interpolation because ModuleNotFoundError: No module named 'tensorflow'

Check that you properly installed the dependencies.
If you think this is a bug, please report it on the github page (https://github.com/melMass/comfy_mtb/issues)
[comfy_mtb] | INFO -> Loaded the following nodes:
Smart Step (mtb): Utils to control the steps start/stop of the KAdvancedSampler in percentage
Text To Image (mtb): Utils to convert text to image using a font
Styles Loader (mtb): Load csv files and populate a dropdown from the rows (à la A111)
B Box From Mask (mtb): From a mask extract the bounding box
Bounding Box (mtb): The bounding box (BBOX) custom type used by other nodes
Crop (mtb): Crops an image and an optional mask to a given bounding box
Uncrop (mtb): Uncrops an image to a given bounding box
Deep Bump (mtb): Normal & height maps generation from single pictures
Save Tensors (mtb): Debug node that will probably be removed in the future
Color Correct (mtb): Various color correction methods
Hsv To Rgb (mtb): Convert HSV image to RGB
Rgb To Hsv (mtb): Convert RGB image to HSV
Image Compare (mtb): Compare two images and return a difference image
Denoise (mtb): Denoise an image using total variation minimization.
Blur (mtb): Blur an image using a Gaussian filter.
Deglaze Image (mtb): Remove adversarial noise from images
Mask To Image (mtb): Converts a mask (alpha) to an RGB image with a color and background
Colored Image (mtb): Constant color image of given size
Image Premultiply (mtb): Premultiply image with mask
Image Resize Factor (mtb): Extracted mostly from WAS Node Suite, with a few edits (most notably multiple image support) and less features.
Save Image Grid (mtb): Save all the images in the input batch as a grid of images.
Latent Lerp (mtb): Linear interpolation (blend) between two latent vectors
Image Remove Background Rembg (mtb): -
Int To Number (mtb): Node addon for the WAS Suite. Converts a "comfy" INT to a NUMBER.
Load Image Sequence (mtb): Load an image sequence from a folder. The current frame is used to determine which image to load.
Save Image Sequence (mtb): Save an image sequence to a folder. The current frame is used to determine which image to save.
Total VRAM 24564 MB, total RAM 130813 MB
xformers version: 0.0.20
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 4090
WAS Node Suite: BlenderNeko's Advanced CLIP Text Encode found, attempting to enable CLIPTextEncode support.
WAS Node Suite: CLIPTextEncode (BlenderNeko Advanced + NSP) node enabled under WAS Suite/Conditioning menu.
WAS Node Suite: OpenCV Python FFMPEG support is enabled
WAS Node Suite Warning: ffmpeg_bin_path is not set in D:\ComfyUI\ComfyUI\custom_nodes\was-node-suite-comfyui\was_suite_config.json config file. Will attempt to use system ffmpeg binaries if available.
WAS Node Suite: Finished. Loaded 186 nodes successfully.

    "Success is not just about making money. It's about making a difference." - Unknown

Import times for custom nodes:
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\sampler_rescalecfg.py
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\sampler_tonemap.py
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\Textnode.py
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\advanced_model_merging.py
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_TiledKSampler
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_ADV_CLIP_emb
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Comfyroll_CustomNodes
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_SeeCoder
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\images-grid-comfy-plugin
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Custom-Scripts
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-QualityOfLifeSuit_Omar92
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\Derfuu_ComfyUI_ModdedNodes
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Noise
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Dave_CustomNode
0.1 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-WD14-Tagger
0.1 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Workflow-Component
0.2 seconds: D:\ComfyUI\ComfyUI\custom_nodes\comfy_mtb
0.3 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Manager
0.4 seconds: D:\ComfyUI\ComfyUI\custom_nodes\clipseg.py
0.5 seconds: D:\ComfyUI\ComfyUI\custom_nodes\comfy_controlnet_preprocessors
0.7 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_tinyterraNodes
0.8 seconds: D:\ComfyUI\ComfyUI\custom_nodes\was-node-suite-comfyui
1.1 seconds: D:\ComfyUI\ComfyUI\custom_nodes\efficiency-nodes-comfyui
1.2 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Impact-Pack

Starting server

To see the GUI go to: http://127.0.0.1:8188
QualityOfLifeSuit_Omar92::NSP ready

@melMass
Copy link
Owner

melMass commented Jul 18, 2023

It seems like there are two things remaining:

The new version will be released later today (around 6h from now 😀)

@rethink-studios
Copy link
Author

OOOPPSS!
Sorry about that..

Here's my log after running "pip install -r requirements.txt:

(base) D:\ComfyUI\ComfyUI\custom_nodes\comfy_mtb>pip install -r requirements.txt
Ignoring tensorflow: markers 'platform_system != "Windows"' don't match your environment
Collecting gdown@ git+https://github.com/melMass/gdown@main (from -r requirements.txt (line 17))
Cloning https://github.com/melMass/gdown (to revision main) to c:\users\rethink\appdata\local\temp\pip-install-sxoj1r46\gdown_0563c6354dc64f999127a8be062bb403
Running command git clone --filter=blob:none --quiet https://github.com/melMass/gdown 'C:\Users\RETHINK\AppData\Local\Temp\pip-install-sxoj1r46\gdown_0563c6354dc64f999127a8be062bb403'
Resolved https://github.com/melMass/gdown to commit 57ea784c863290da4b880c035f99edad854234c3
Running command git submodule update --init --recursive -q
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
Collecting onnxruntime-gpu==1.15.1 (from -r requirements.txt (line 1))
Using cached onnxruntime_gpu-1.15.1-cp39-cp39-win_amd64.whl (122.5 MB)
Collecting imageio===2.28.1 (from -r requirements.txt (line 2))
Using cached imageio-2.28.1-py3-none-any.whl (3.4 MB)
Collecting qrcode[pil] (from -r requirements.txt (line 3))
Using cached qrcode-7.4.2-py3-none-any.whl (46 kB)
Collecting numpy==1.23.5 (from -r requirements.txt (line 4))
Using cached numpy-1.23.5-cp39-cp39-win_amd64.whl (14.7 MB)
Collecting insightface==0.7.3 (from -r requirements.txt (line 5))
Using cached insightface-0.7.3.tar.gz (439 kB)
Installing build dependencies ... done
Getting requirements to build wheel ... done
Installing backend dependencies ... done
Preparing metadata (pyproject.toml) ... done
Collecting mmcv==2.0.0 (from -r requirements.txt (line 6))
Using cached mmcv-2.0.0.tar.gz (473 kB)
Preparing metadata (setup.py) ... error
error: subprocess-exited-with-error

× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [14 lines of output]
Traceback (most recent call last):
File "", line 2, in
File "", line 34, in
File "C:\Users\RETHINK\AppData\Local\Temp\pip-install-sxoj1r46\mmcv_00b42624230c46d08eb947bebf58265f\setup.py", line 343, in
ext_modules=get_extensions(),
File "C:\Users\RETHINK\AppData\Local\Temp\pip-install-sxoj1r46\mmcv_00b42624230c46d08eb947bebf58265f\setup.py", line 304, in get_extensions
ext_ops = extension(
File "C:\Users\RETHINK\anaconda3\lib\site-packages\torch\utils\cpp_extension.py", line 1048, in CUDAExtension
library_dirs += library_paths(cuda=True)
File "C:\Users\RETHINK\anaconda3\lib\site-packages\torch\utils\cpp_extension.py", line 1186, in library_paths
paths.append(_join_cuda_home(lib_dir))
File "C:\Users\RETHINK\anaconda3\lib\site-packages\torch\utils\cpp_extension.py", line 2223, in _join_cuda_home
raise EnvironmentError('CUDA_HOME environment variable is not set. '
OSError: CUDA_HOME environment variable is not set. Please set it to your CUDA install root.
[end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

@melMass melMass added the mode: 🎒 comfy-embed Related to the comfy embed mode label Jul 18, 2023
@melMass
Copy link
Owner

melMass commented Jul 18, 2023

As you are using comfy-embed you must use .\python_embeded\python.exe -m pip install instead of pip install from the log it seems to have picked up an anaconda env

@rethink-studios
Copy link
Author

Third times a charm?

(base) D:\ComfyUI\ComfyUI\custom_nodes\comfy_mtb>d:\ComfyUI\python_embeded\python.exe -m pip install -r requirements.txt
Ignoring tensorflow: markers 'platform_system != "Windows"' don't match your environment
Collecting gdown@ git+https://github.com/melMass/gdown@main (from -r requirements.txt (line 17))
Cloning https://github.com/melMass/gdown (to revision main) to c:\users\rethink\appdata\local\temp\pip-install-144y8qk5\gdown_69ea027033ad4fbca9edc1f61176288e
Running command git clone --filter=blob:none --quiet https://github.com/melMass/gdown 'C:\Users\RETHINK\AppData\Local\Temp\pip-install-144y8qk5\gdown_69ea027033ad4fbca9edc1f61176288e'
Resolved https://github.com/melMass/gdown to commit 57ea784c863290da4b880c035f99edad854234c3
Running command git submodule update --init --recursive -q
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
Collecting onnxruntime-gpu==1.15.1 (from -r requirements.txt (line 1))
Obtaining dependency information for onnxruntime-gpu==1.15.1 from https://files.pythonhosted.org/packages/67/4c/03519d7dd781537083b8a0badfc15f6e334b3f7ba227a544860ded5c7157/onnxruntime_gpu-1.15.1-cp310-cp310-win_amd64.whl.metadata
Using cached onnxruntime_gpu-1.15.1-cp310-cp310-win_amd64.whl.metadata (4.1 kB)
Requirement already satisfied: imageio===2.28.1 in d:\comfyui\python_embeded\lib\site-packages (from -r requirements.txt (line 2)) (2.28.1)
Collecting qrcode[pil] (from -r requirements.txt (line 3))
Using cached qrcode-7.4.2-py3-none-any.whl (46 kB)
Requirement already satisfied: numpy==1.23.5 in d:\comfyui\python_embeded\lib\site-packages (from -r requirements.txt (line 4)) (1.23.5)
Collecting insightface==0.7.3 (from -r requirements.txt (line 5))
Using cached insightface-0.7.3.tar.gz (439 kB)
Installing build dependencies ... done
Getting requirements to build wheel ... error
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [15 lines of output]
Traceback (most recent call last):
File "d:\ComfyUI\python_embeded\lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 353, in
main()
File "d:\ComfyUI\python_embeded\lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
File "d:\ComfyUI\python_embeded\lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 118, in get_requires_for_build_wheel
return hook(config_settings)
File "d:\ComfyUI\python_embeded\lib\site-packages\setuptools\build_meta.py", line 341, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=['wheel'])
File "d:\ComfyUI\python_embeded\lib\site-packages\setuptools\build_meta.py", line 323, in _get_build_requires
self.run_setup()
File "d:\ComfyUI\python_embeded\lib\site-packages\setuptools\build_meta.py", line 338, in run_setup
exec(code, locals())
File "", line 11, in
ModuleNotFoundError: No module named 'Cython'
[end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

(base) D:\ComfyUI\ComfyUI\custom_nodes\comfy_mtb>

@DarkCoverUnleashed
Copy link

Has there been any update to this?

@Piscabo
Copy link

Piscabo commented Jul 21, 2023

Tried any and every fix I could find, no luck with this?
[comfy_mtb] | WARNING -> cv2.ximgproc.guidedFilter not found, use opencv-contrib-python
[comfy_mtb] | ERROR -> Some nodes failed to load:
Failed to import faceswap because ModuleNotFoundError: No module named 'onnx.onnx_cpp2py_export.checker'; 'onnx.onnx_cpp2py_export' is not a package
Failed to import fun because ModuleNotFoundError: No module named 'png'

@melMass
Copy link
Owner

melMass commented Jul 21, 2023

That's unfortunate...
I just checked quickly with the extensions I use and: Controlnetpreprocessors, ImpactPack, DaveCustomNodes and Disco Diffusion also install onnx... I will check which is using an older version later today!

@Piscabo
Copy link

Piscabo commented Jul 22, 2023

It might be roop itself, it started after I added the roop custom_nodes . I'm not 100% sure
image

@melMass
Copy link
Owner

melMass commented Jul 22, 2023

It might be roop itself, it started after I added the roop custom_nodes . I'm not 100% sure

Can you try again ideally following the new instructions, i.e using Comfy-Manager

https://github.com/melMass/comfy_mtb/blob/main/INSTALL.md

@Piscabo
Copy link

Piscabo commented Jul 23, 2023

ERROR: Could not install packages due to an OSError: [WinError 5] Access is denied: 'A:\AI_Files\ComfyUI_windows_portable\python_embeded\Lib\site-packages\google\~-otobuf\internal\_api_implementation.cp310-win_amd64.pyd' Consider using the --user option or check the permissions.

[comfy_mtb] | INFO -> Some nodes failed to load:
Failed to import module faceswap because ImportError: cannot import name 'builder' from 'google.protobuf.internal' (A:\AI_Files\ComfyUI_windows_portable\python_embeded\lib\site-packages\google\protobuf\internal_init_.py)

Check that you properly installed the dependencies.
If you think this is a bug, please report it on the github page (https://github.com/melMass/comfy_mtb/issues)
[comfy_mtb] | INFO -> Loaded the following nodes:
The install does not complete sucessfully and breaks these 2 nodes:
image

@melMass
Copy link
Owner

melMass commented Jul 23, 2023

My guess is it's Comfy Roop and mtb that have incompatibilities since I've tested the install from scratch on all modes.

I will try Comfy roop next week, and honestly if it does exactly what my node do I will just remove FaceSwap, 90% of the dependency issues come from it.

Also as said before all other nodes will work fine if a few fail, maybe I'll remove auto install for the "extra" nodes and add manual install instructions. I don't want to spend this much time on solving all the various user configs which for now more than half the time I dedicate to this project is...

@Piscabo
Copy link

Piscabo commented Jul 23, 2023

My guess is it's Comfy Roop and mtb that have incompatibilities since I've tested the install from scratch on all modes.

I will try Comfy roop next week, and honestly if it does exactly what my node do I will just remove FaceSwap, 90% of the dependency issues come from it.

Also as said before all other nodes will work fine if a few fail, maybe I'll remove auto install for the "extra" nodes and add manual install instructions. I don't want to spend this much time on solving all the various user configs which for now more than half the time I dedicate to this project is...

Sorry, I don't mean to cause you headaches, thanks so much for what you are doing. I'm not moaning at you... more like moaning with you. I will figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mode: 🎒 comfy-embed Related to the comfy embed mode type: 🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants