[bug] basicsr whl requires the future whl too #35
Comments
melMass
added
type: 🐛 bug
|
I did:
my logD:\2023\OneDrive\klingit\stable_diffusion_xl\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfy_mtb>pip install -r requirements-wheels.txt
Collecting insightface==0.7.3 (from -r requirements-wheels.txt (line 1))
Using cached insightface-0.7.3.tar.gz (439 kB)
Installing build dependencies ... done
Getting requirements to build wheel ... done
Installing backend dependencies ... done
Preparing metadata (pyproject.toml) ... done
Collecting mmcv==2.0.0 (from -r requirements-wheels.txt (line 2))
Using cached mmcv-2.0.0.tar.gz (473 kB)
Preparing metadata (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [18 lines of output]
Traceback (most recent call last):
File "<string>", line 2, in <module>
File "<pip-setuptools-caller>", line 34, in <module>
File "C:\Users\joe\AppData\Local\Temp\pip-install-pw4jw4ss\mmcv_8e3bb0d0977742ec832dc2cdc48409d3\setup.py", line 343, in <module>
ext_modules=get_extensions(),
^^^^^^^^^^^^^^^^
File "C:\Users\joe\AppData\Local\Temp\pip-install-pw4jw4ss\mmcv_8e3bb0d0977742ec832dc2cdc48409d3\setup.py", line 304, in get_extensions
ext_ops = extension(
^^^^^^^^^^
File "C:\Users\joe\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0\LocalCache\local-packages\Python311\site-packages\torch\utils\cpp_extension.py", line 1048, in CUDAExtension
library_dirs += library_paths(cuda=True)
^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\joe\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0\LocalCache\local-packages\Python311\site-packages\torch\utils\cpp_extension.py", line 1186, in library_paths
paths.append(_join_cuda_home(lib_dir))
^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\joe\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0\LocalCache\local-packages\Python311\site-packages\torch\utils\cpp_extension.py", line 2223, in _join_cuda_home
raise EnvironmentError('CUDA_HOME environment variable is not set. '
OSError: CUDA_HOME environment variable is not set. Please set it to your CUDA install root.
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output. |
|
Yes thanks, I know the issue now (it's the title of this issue) |
melMass
added
mode: 🎒 comfy-embed
|
Ah no... what you just did is wrong. But what you stated in #1 will help to solve the auto install |
|
What do you mean? Sorry I’m confused now? |
|
Ahah sorry! The reason some pip dependencies need to build from source is that the matrix (your OS, hardware, python version etc) of your system doesn't have "published wheels" i.e prebuilt packages built specifically for your matrix hosted on pip servers. In this case all the build instructions run, but fail in the portable case. TLDRI need to include extra whl files in the next release that I missed as they are not direct dependencies but dependencies of dependencies 😅 |
|
Yes thanks, that’s what I thought, but I also thought I had installed the missing .whl’s. anyway I’ll wait for the next release. thanks :) |
|
@techoutsider Can you try again, it should have been fixed in https://github.com/melMass/comfy_mtb/releases/tag/v0.1.2
|
|
it still gives me the error **Total VRAM 10239 MB, total RAM 130980 MB
xformers version: 0.0.20
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3080 : cudaMallocAsync
Using xformers cross attention
### Loading: ComfyUI-Manager (V0.16)
### ComfyUI Revision: 1216 [fbf5c51c]
Log level: 20
[comfy_mtb] | WARNING -> Web extensions folder at D:\2023\OneDrive\klingit\stable_diffusion_xl\ComfyUI_windows_portable\ComfyUI\web\extensions\mtb is not a symlink, if updating please delete it before
D:\2023\OneDrive\klingit\stable_diffusion_xl\ComfyUI_windows_portable\python_embeded\lib\site-packages\torchvision\transforms\functional_tensor.py:5: UserWarning: The torchvision.transforms.functional_tensor module is deprecated in 0.15 and will be **removed in 0.17**. Please don't rely on it. You probably just need to use APIs in torchvision.transforms.functional or in torchvision.transforms.v2.functional.
warnings.warn(
RestoreFace
LoadFaceEnhanceModel
[comfy_mtb] | INFO -> Some nodes failed to load:
Failed to import module faceenhance because ModuleNotFoundError: No module named 'facexlib'
Check that you properly installed the dependencies.
If you think this is a bug, please report it on the github page (https://github.com/melMass/comfy_mtb/issues)
[comfy_mtb] | INFO -> Loaded the following nodes:
Animation Builder (mtb): Convenient way to manage basic animation maths at the core of many of my workflows
Smart Step (mtb): Utils to control the steps start/stop of the KAdvancedSampler in percentage
Text To Image (mtb): Utils to convert text to image using a font
Styles Loader (mtb): Load csv files and populate a dropdown from the rows (à la A111)
Bbox From Mask (mtb): From a mask extract the bounding box
Bbox (mtb): The bounding box (BBOX) custom type used by other nodes
Crop (mtb): Crops an image and an optional mask to a given bounding box
Uncrop (mtb): Uncrops an image to a given bounding box
Debug (mtb): Experimental node to debug any Comfy values, support for more types and widgets is planned
Save Tensors (mtb): Save torch tensors (image, mask or latent) to disk, useful to debug things outside comfy
Deep Bump (mtb): Normal & height maps generation from single pictures
Face Swap (mtb): Face swap using deepinsight/insightface models
Load Face Swap Model (mtb): Loads a faceswap model
Load Face Analysis Model (mtb): Loads a face analysis model
Qr Code (mtb): Basic QR Code generator
Unsplash Image (mtb): Unsplash Image given a keyword and a size
String Replace (mtb): Basic string replacement
Fit Number (mtb): Fit the input float using a source and target range
Load Film Model (mtb): Loads a FILM model
Film Interpolation (mtb): Google Research FILM frame interpolation for large motion
Concat Images (mtb): Add images to batch
Get Batch From History (mtb): Very experimental node to load images from the history of the server.
Color Correct (mtb): Various color correction methods
Image Compare (mtb): Compare two images and return a difference image
Blur (mtb): Blur an image using a Gaussian filter.
Mask To Image (mtb): Converts a mask (alpha) to an RGB image with a color and background
Colored Image (mtb): Constant color image of given size
Image Premultiply (mtb): Premultiply image with mask
Image Resize Factor (mtb): Extracted mostly from WAS Node Suite, with a few edits (most notably multiple image support) and less features.
Save Image Grid (mtb): Save all the images in the input batch as a grid of images.
Load Image From Url (mtb): Load an image from the given URL
Save Gif (mtb): Save the images from the batch as a GIF
Export To Prores (mtb): Export to ProRes 4444 (Experimental)
Latent Lerp (mtb): Linear interpolation (blend) between two latent vectors
Image Remove Background Rembg (mtb): Removes the background from the input using Rembg.
Float To Number (mtb): Node addon for the WAS Suite. Converts a "comfy" FLOAT to a NUMBER.
Int To Bool (mtb): Basic int to bool conversion
Int To Number (mtb): Node addon for the WAS Suite. Converts a "comfy" INT to a NUMBER.
Transform Image (mtb): Save torch tensors (image, mask or latent) to disk, useful to debug things outside comfy
Load Image Sequence (mtb): Load an image sequence from a folder. The current frame is used to determine which image to load.
Save Image Sequence (mtb): Save an image sequence to a folder. The current frame is used to determine which image to save.
Total VRAM 10239 MB, total RAM 130980 MB
xformers version: 0.0.20
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3080 : cudaMallocAsync
WAS Node Suite: OpenCV Python FFMPEG support is enabled
WAS Node Suite Warning: `ffmpeg_bin_path` is not set in `D:\2023\OneDrive\klingit\stable_diffusion_xl\ComfyUI_windows_portable\ComfyUI\custom_nodes\was-node-suite-comfyui\was_suite_config.json` config file. Will attempt to use system ffmpeg binaries if available.
WAS Node Suite: Finished. Loaded 187 nodes successfully.
"Every great dream begins with a dreamer." - Harriet Tubman** |
|
Did you update it? That just the output of launching comfy, on update install should be ran again |
|
Ah sorry posted the wrong copy pasta, yes I updated it, has the error when installing seemed the same as the one before. Will paste it when I’m back at pc |
|
I think I know what might happen... the whl are installed in order so basicsr is installed first and tries to build future.. I'll push a fix |
|
I pushed the fix I mentioned so on update it should pickup the order now |
|
i used the comfyui manager, got errors, ####################################################################### Execute install/(de)activation script for 'D:\2023\OneDrive\klingit\stable_diffusion_xl\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfy_mtb'Ignoring tensorflow: markers 'platform_system != "Windows"' don't match your environment × python setup.py egg_info did not run successfully. note: This error originates from a subprocess, and is likely not a problem with pip. × Encountered error while generating package metadata. note: This is an issue with the package mentioned above, not pip. Execute install/(de)activation script for 'D:\2023\OneDrive\klingit\stable_diffusion_xl\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfy_mtb'[mtb install] No arguments provided, doing a full install/update... × Building wheel for pycocotools (pyproject.toml) did not run successfully. note: This error originates from a subprocess, and is likely not a problem with pip. × python setup.py egg_info did not run successfully. note: This error originates from a subprocess, and is likely not a problem with pip. × Encountered error while generating package metadata. note: This is an issue with the package mentioned above, not pip. [ComfyUI-Manager] Startup script completed. |
|
Should be fixed in https://github.com/melMass/comfy_mtb/releases/tag/v0.1.3 So just update from Comfy-Manager and don't run anything else :) |
|
Nice with a quick check, it seems to be working! |
|
I did notice in your node list there was colour nodes, hsv - rgb and rgb - hsv, which i dont appear to have, but other than that i dont seem to have any errors :) |
|
That's expected! The node list is outdated, I think I only removed the few you mentioned, but added others that are not yet properly documented! I will keep this issue open until I merge #41 EDIT: there is actually a way to check in the browser, by adding |
|
Shame seemed like a nice node to have, but then everything is working as expected! /status is nice!!! |
Describe the bug
Migrated from #1 by @techoutsider
Reproduction
No response
Expected behavior
No response
Platform and versions
Console output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: