Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using a PPX without passing the dependency on #325

Closed
mlms13 opened this issue Jun 29, 2022 · 2 comments
Closed

Allow using a PPX without passing the dependency on #325

mlms13 opened this issue Jun 29, 2022 · 2 comments

Comments

@mlms13
Copy link
Contributor

mlms13 commented Jun 29, 2022

The problem:

Bastet, Relude, and presumably other libraries make use of bisect_ppx during development/CI to collect test coverage stats. In an ideal world, users of those libraries wouldn't also have to depend on bisect_ppx, because it's a dev-only tool that at various points has caused pain when building on Windows, with the Rescript compiler, etc. Currently, I don't believe it's possible to make it a devDependency, because the ppx-flagsfield in our bsconfig will try to run during every build, and it will fail in this case if it doesn't find bisect_ppx.

Maybe a potential solution:

@aantron had proposed adding a "dev" version of the ppx-flags field to bsconfig.json. This could theoretically allow users of Relude to build a non-development version of the library that skips the bisect_ppx step. There was even a Bucklescript PR that attempted to fix this, but it was never merged.

Related info:

@anmonteiro
Copy link
Member

This is related to #192 and #92

@anmonteiro
Copy link
Member

Same reasoning as #92, we'll get dune profiles for free with the deeper dune integration.

@anmonteiro anmonteiro closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants