Bump version number. Lib: Fix potential crash in newReleasesFromFavoriteArtists().

melgu · melgu · commit 897c7445c81d · 2020-08-15T06:51:48.000+02:00
diff --git a/TidalSwift.xcodeproj/project.pbxproj b/TidalSwift.xcodeproj/project.pbxproj
@@ -1444,7 +1444,7 @@
 				CODE_SIGN_IDENTITY = "Apple Development";
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
-				CURRENT_PROJECT_VERSION = 29;
+				CURRENT_PROJECT_VERSION = 30;
 				DEVELOPMENT_ASSET_PATHS = "TidalSwift/Preview\\ Content";
 				DEVELOPMENT_TEAM = V7E5P7292M;
 				ENABLE_HARDENED_RUNTIME = YES;
@@ -1474,7 +1474,7 @@
 				CODE_SIGN_IDENTITY = "Apple Development";
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
-				CURRENT_PROJECT_VERSION = 29;
+				CURRENT_PROJECT_VERSION = 30;
 				DEVELOPMENT_ASSET_PATHS = "TidalSwift/Preview\\ Content";
 				DEVELOPMENT_TEAM = V7E5P7292M;
 				ENABLE_HARDENED_RUNTIME = YES;
diff --git a/TidalSwiftLib/Codables/Albums.swift b/TidalSwiftLib/Codables/Albums.swift
@@ -113,7 +113,7 @@ public enum AlbumSorting: Int, Codable {
 }
 
 extension Array where Element == Album {
-	public func sortedAlbums(by sorting: AlbumSorting) -> [Album] {
+	public func sortedAlbums(by sorting: AlbumSorting) -> [Album] { // TODO: Add reversed parameter
 		switch sorting {
 		case .dateAdded:
 			return self
diff --git a/TidalSwiftLib/Helpers.swift b/TidalSwiftLib/Helpers.swift
@@ -38,7 +38,7 @@ public class Helpers {
 			allReleases += albums
 		}
 		
-		allReleases.sort { $0.releaseDate! > $1.releaseDate! }
+		allReleases.sort { $0.releaseDate ?? Date.distantPast > $1.releaseDate ?? Date.distantPast }
 		return Array(allReleases.prefix(number))
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ public enum AlbumSorting: Int, Codable {`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`extension Array where Element == Album {`
`116`		`- public func sortedAlbums(by sorting: AlbumSorting) -> [Album] {`
	`116`	`+ public func sortedAlbums(by sorting: AlbumSorting) -> [Album] { // TODO: Add reversed parameter`
`117`	`117`	`switch sorting {`
`118`	`118`	`case .dateAdded:`
`119`	`119`	`return self`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public class Helpers {`
`38`	`38`	`allReleases += albums`
`39`	`39`	`}`
`40`	`40`
`41`		`- allReleases.sort { $0.releaseDate! > $1.releaseDate! }`
	`41`	`+ allReleases.sort { $0.releaseDate ?? Date.distantPast > $1.releaseDate ?? Date.distantPast }`
`42`	`42`	`return Array(allReleases.prefix(number))`
`43`	`43`	`}`
`44`	`44`	`}`