Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing a baseurl as a prop #227

Closed
Nicholson85 opened this issue Feb 14, 2019 · 3 comments
Closed

Passing a baseurl as a prop #227

Nicholson85 opened this issue Feb 14, 2019 · 3 comments

Comments

@Nicholson85
Copy link

Is this a bug report or a feature request?

Feature Request

Apologies if this comes across is a dumb question but I was just wondering. Is it possible to provide a 'baseurl' as a prop similar to a webview which would then be prepended to any relative paths in the html. I am aware this could be done by using custom renderers but was unsure if there was a simpler way.

Thanks.

@Exilz
Copy link
Contributor

Exilz commented Feb 25, 2019

We could add it as a prop in the future. It would need to affect all the default renderers and be available in the parameters of the custom renderers, though.
This shouldn't be too complicated but there are quite a lot of code changes to make. I don't plan on making it myself in the near future, but I'm open to reviewing a pull request and merging it.

I'm not sure this is a feature needed by many, so I wouldn't make that a priority. 😄

@jsamr
Copy link
Collaborator

jsamr commented Feb 7, 2021

This feature is available in the foundry pre-release (see #430 for instruction on how to try it out). You can now use source.baseUrl prop to achieve that purpose.

@jsamr
Copy link
Collaborator

jsamr commented Jun 8, 2021

Closing now since the stable beta which fixes this issue has just been released.

@jsamr jsamr closed this as completed Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants