Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to inject system properties into JApiCmpWorkAction worker #83

Closed
NielsDoucet opened this issue Nov 8, 2024 · 0 comments · Fixed by #86
Closed

Option to inject system properties into JApiCmpWorkAction worker #83

NielsDoucet opened this issue Nov 8, 2024 · 0 comments · Fixed by #86

Comments

@NielsDoucet
Copy link
Contributor

japicmp-gradle-plugin/src/main/java/me/champeau/gradle/japicmp/JapicmpTask.java

Lines 73 to 85 in 930bbfd

private void execForNewGradle(final List<JApiCmpWorkerAction.Archive> baseline, final List<JApiCmpWorkerAction.Archive> current) {
getWorkerExecutor().processIsolation(new Action<ProcessWorkerSpec>() {
@Override
public void execute(ProcessWorkerSpec spec) {
spec.getClasspath().from(calculateWorkerClasspath());
}
}).submit(JApiCmpWorkAction.class, new Action<JapiCmpWorkParameters>() {
@Override
public void execute(JapiCmpWorkParameters params) {
params.getConfiguration().set(calculateWorkerConfiguration(baseline, current));
}
});
}

Would you allow injecting system properties into the worker process here?
We have a use case where we need to adjust some rules' behavior based on properties in our custom extension.
This seems currently only possible by configuring these rules in an afterEvaluate block, which I'd like to avoid.

If we had an option to inject system properties into the worker, it would be possible to influence a rule's behavior through these using a doFirst action on the JapicmpTask.
NielsDoucet added a commit to NielsDoucet/japicmp-gradle-plugin that referenced this issue Nov 29, 2024
@NielsDoucet
Introduce optional workerSystemProperties.
589a2f9 
This MapProperty allows to pass in system properties to the forked
worker process that executes the api compare work action.

fixes melix#83
NielsDoucet added a commit to NielsDoucet/japicmp-gradle-plugin that referenced this issue Nov 29, 2024
@NielsDoucet
Introduce optional workerSystemProperties.
9c0255b 
This MapProperty allows to pass in system properties to the forked
worker process that executes the api compare work action.

fixes melix#83
@NielsDoucet NielsDoucet mentioned this issue Nov 29, 2024
Merged
@melix melix closed this as completed in #86 Jan 17, 2025
melix pushed a commit that referenced this issue Jan 17, 2025
@NielsDoucet @melix
Introduce optional workerSystemProperties.
8f65f5c 
This MapProperty allows to pass in system properties to the forked
worker process that executes the api compare work action.

fixes #83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce optional workerSystemProperties NielsDoucet/japicmp-gradle-plugin
1 participant
@NielsDoucet