Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument type mismatch between getTile[Id] and setTile/clearTile #107

Closed
parasyte opened this issue Sep 17, 2012 · 2 comments
Closed

Argument type mismatch between getTile[Id] and setTile/clearTile #107

parasyte opened this issue Sep 17, 2012 · 2 comments

Comments

@parasyte
Copy link
Collaborator

me.TiledLayer has four functions for accessing and modifying the tiles in the layer, but the x,y arguments passed to each function do not match:

  • getTile and getTileId accept the coordinates in pixels
  • setTile and clearTile accept the coordinates in tiles

The difference is not evident in documentation: http://www.melonjs.org/docs/symbols/me.TiledLayer.html

@melonjs melonjs closed this as completed in 217527f Oct 1, 2012
@melonjs
Copy link
Collaborator

melonjs commented Oct 3, 2012

@parasyte based on the ticket title I just changed the documenation, but after seeing the point listed in roadmap, were you actually having in mind changing the arguments (normalize them) ?

@parasyte
Copy link
Collaborator Author

parasyte commented Oct 3, 2012

Either one is a valid solution, I think. I figured while we were making other breaking changes, we might do this too. But I'm ok with leaving it a documentation-only change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant