Skip to content

Commit cb163bf

Browse files
fix(taps): Check replication method instead of key to determine if a SQL stream is sorted (#2418)
1 parent 5d66569 commit cb163bf

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

singer_sdk/streams/sql.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import singer_sdk.helpers._catalog as catalog
1212
from singer_sdk._singerlib import CatalogEntry, MetadataMapping
1313
from singer_sdk.connectors import SQLConnector
14-
from singer_sdk.streams.core import Stream
14+
from singer_sdk.streams.core import REPLICATION_INCREMENTAL, Stream
1515

1616
if t.TYPE_CHECKING:
1717
from singer_sdk.helpers.types import Context
@@ -227,7 +227,7 @@ def is_sorted(self) -> bool:
227227
Returns:
228228
`True` if stream is sorted. Defaults to `False`.
229229
"""
230-
return self.replication_key is not None
230+
return self.replication_method == REPLICATION_INCREMENTAL
231231

232232

233233
__all__ = ["SQLConnector", "SQLStream"]

0 commit comments

Comments
 (0)