Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Consider moving cookiecutter tests to root of generated project to facilitate test discovery #1377

Closed
edgarrmondragon opened this issue Feb 1, 2023 · 4 comments · Fixed by #1380
Assignees
Labels
kind/Bug Something isn't working valuestream/SDK

Comments

@edgarrmondragon
Copy link
Collaborator

Singer SDK Version

0.19.0

Python Version

NA

Bug scope

Other

Operating System

Any

Description

See #1370 (comment)

Aha! Yes, that solved this. I also had to update pytest and, along with that, move the tests folder out into the rootdir of the repo, from tap-postgres/tap-postgres/tests/ -> tap-postgres/tests/. Thank you!!

Code

No response

@edgarrmondragon edgarrmondragon added kind/Bug Something isn't working valuestream/SDK labels Feb 1, 2023
@edgarrmondragon edgarrmondragon self-assigned this Feb 1, 2023
@qbatten
Copy link
Contributor

qbatten commented Feb 1, 2023

Specifically, pytest >=4.0 requires you to do this if you're defining pytest_plugins https://docs.pytest.org/en/7.1.x/deprecations.html#pytest-plugins-in-non-top-level-conftest-files. AIUI.

@edgarrmondragon
Copy link
Collaborator Author

Thanks for the additional context @qbatten!

@menzenski
Copy link
Contributor

I am seeing this issue with SDK version 0.22.1 and tests/ in the top level repository directory.

Tests directory: https://github.com/menzenski/tap-mongodb/blob/main/tests/core_test.py
Failing tests: https://github.com/menzenski/tap-mongodb/actions/runs/4635115290/jobs/8201896087#step:7:24

@edgarrmondragon
Copy link
Collaborator Author

@menzenski were you able to fix this by adding a tests/conftest.py?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/Bug Something isn't working valuestream/SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants