Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Retry some streaming and decoding request errors #1478

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

visch
Copy link
Contributor

@visch visch commented Mar 4, 2023

Recieved a few of these errors in production with long running jobs, retries will now save the day!


📚 Documentation preview 📚: https://meltano-sdk--1478.org.readthedocs.build/en/1478/

@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #1478 (6621c4f) into main (1238def) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 6621c4f differs from pull request most recent head 74c6b27. Consider uploading reports for the commit 74c6b27 to get more accurate results

@@            Coverage Diff             @@
##             main    #1478      +/-   ##
==========================================
+ Coverage   85.44%   85.46%   +0.01%     
==========================================
  Files          57       57              
  Lines        4762     4760       -2     
  Branches      809      809              
==========================================
- Hits         4069     4068       -1     
+ Misses        502      501       -1     
  Partials      191      191              
Impacted Files Coverage Δ
singer_sdk/streams/rest.py 86.41% <ø> (+0.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon changed the title feat: More retries to save the day for RESTStreams feat: Retry some streaming and decoding request errors Mar 6, 2023
@edgarrmondragon edgarrmondragon merged commit 44aa0a0 into meltano:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants