Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break: Require SQLAlchemy 2.0 for SQL taps and targets #1667

Open
7 of 8 tasks
Tracked by #1
edgarrmondragon opened this issue May 3, 2023 · 5 comments · Fixed by #1916
Open
7 of 8 tasks
Tracked by #1

break: Require SQLAlchemy 2.0 for SQL taps and targets #1667

edgarrmondragon opened this issue May 3, 2023 · 5 comments · Fixed by #1916
Assignees
Labels
Dependencies kind/Feature New feature or request SQL Support for SQL taps and targets valuestream/SDK
Milestone

Comments

@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented May 3, 2023

Feature scope

Taps (catalog, state, stream maps, etc.)

Description

We should require new taps and targets use SQLAlchemy 2.0 to avoid having to migrate them later, and come up with a migration plan for existing ones.

Most of the compatibility work was done in #1357, but individual connectors may still be using deprecated APIs.

Ecosystem Support

Related:

@edgarrmondragon
Copy link
Collaborator Author

#1484 adds support for SQLAlchemy 2.* without introducing breaking changes

@edgarrmondragon edgarrmondragon self-assigned this Jul 13, 2023
@edgarrmondragon edgarrmondragon linked a pull request Aug 18, 2023 that will close this issue
@edgarrmondragon
Copy link
Collaborator Author

Closed by #1916

@edgarrmondragon
Copy link
Collaborator Author

edgarrmondragon commented Jul 4, 2024

This isn't in main yet, so I'll reopen it. It's tracked by https://github.com/meltano/sdk/milestone/2 anyway.

@edgarrmondragon
Copy link
Collaborator Author

snowflakedb/snowflake-sqlalchemy#514 suggests that snowflake-sqlalchemy 1.6 will support SQLAlchemy 2.0.

@edgarrmondragon
Copy link
Collaborator Author

I added an Ecosystem Support checklist to the issue description. I think those are the major third-party SQLAlchemy dialects. Comment if you know one that's missing!

The only stale one is Redshift, which is used by TicketSwap/target-redshift. I don't wanna get them stuck in an older version of the Singer SDK just yet, so I'll punt this to sometime in 2024 Q1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies kind/Feature New feature or request SQL Support for SQL taps and targets valuestream/SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant