Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE: Investigate order guarantees for log replication in SQL databases #2078

Open
1 task
edgarrmondragon opened this issue Nov 30, 2023 · 0 comments
Open
1 task
Labels
evergreen help wanted Extra attention is needed question Further information is requested SQL Support for SQL taps and targets valuestream/SDK

Comments

@edgarrmondragon
Copy link
Collaborator

Singer SDK Version

0.32.0

Is this a regression?

  • Yes

Python Version

NA

Bug scope

Taps (catalog, state, etc.)

Operating System

NA

Description

#1951 (shipped in v0.32.0) made sure that SQL streams are treated as sorted when a replication key is set, which is the case for INCREMENTAL replication.

However, LOG_BASED replication may also set a replication key on the stream, but some databases (at least Postgres) do not guarantee order under log replication. This means that the original assumption was wrong, so we may need to survey order guarantees in SQL databases to decide if we should update this library.

In the meantime, MeltanoLabs/tap-postgres#301 was opened to address this issue for Postgres.

Code

No response

@edgarrmondragon edgarrmondragon added kind/Bug Something isn't working valuestream/SDK help wanted Extra attention is needed labels Nov 30, 2023
@edgarrmondragon edgarrmondragon added the SQL Support for SQL taps and targets label Jul 21, 2024
@edgarrmondragon edgarrmondragon removed the kind/Bug Something isn't working label Jul 30, 2024
@edgarrmondragon edgarrmondragon changed the title bug: Investigate order guarantees for log replication in SQL databases SPIKE: Investigate order guarantees for log replication in SQL databases Jul 30, 2024
@edgarrmondragon edgarrmondragon added question Further information is requested evergreen labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
evergreen help wanted Extra attention is needed question Further information is requested SQL Support for SQL taps and targets valuestream/SDK
Projects
None yet
Development

No branches or pull requests

1 participant