-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packaging: Use uv to manage this project #2851
Conversation
Reviewer's Guide by SourceryThis pull request migrates the project from Poetry to uv for dependency management and build processes. It also updates the documentation and CI workflows to reflect this change. Flow diagram: Updated development setup processflowchart TD
Start[Start Development Setup] --> InstallUV[Install uv]
InstallUV --> InstallTools[Install tools with uv]
InstallTools --> |pre-commit| Tools1[Install pre-commit]
InstallTools --> |nox| Tools2[Install nox]
Tools1 --> InstallDeps[Install dependencies]
Tools2 --> InstallDeps
InstallDeps --> |uv sync| AllDeps[Install all dependencies and extras]
AllDeps --> PreCommit[Setup pre-commit hooks]
PreCommit --> Done[Setup Complete]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
0148514
to
f158017
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #2851 will not alter performanceComparing Summary
|
f158017
to
d168fe8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @edgarrmondragon - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a brief explanation in the PR description about the motivation and benefits of switching from Poetry to uv (e.g., performance improvements, simplified dependency management, etc).
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Motivation
urllib3
constraint #2852 which Poetry didn't like)Potential issues
uv.lock
dependabot/dependabot-core#10478, but we don't pin dependencies in distributions of this library, so it's not a big dealSummary by Sourcery
Switch to using
uv
for managing project dependencies and development tools.Build:
poetry
withuv
for managing project dependencies and virtual environments.CI:
uv
instead ofpoetry
.Documentation:
poetry
touv
for managing dependencies and development tools.📚 Documentation preview 📚: https://meltano-sdk--2851.org.readthedocs.build/en/2851/