Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider refactoring external dependencies #928

Closed
aaronsteers opened this issue Aug 26, 2022 · 2 comments · Fixed by #979
Closed

Consider refactoring external dependencies #928

aaronsteers opened this issue Aug 26, 2022 · 2 comments · Fixed by #979

Comments

@aaronsteers
Copy link
Contributor

aaronsteers commented Aug 26, 2022

At this point we have rewritten much of the python libraries and in many cases have used alternative approaches such as new classes and metadata operations. We recently ran into a bug with a nested dependency, and a simple fix is to remove the reference to this library.

Related to:

@aaronsteers aaronsteers changed the title Remove external dependency on pipelinewise-singer-python Consider removing pipelinewise-singer-python dependency Aug 26, 2022
@aaronsteers aaronsteers changed the title Consider removing pipelinewise-singer-python dependency Consider refactoring external dependencies Aug 26, 2022
@edgarrmondragon edgarrmondragon self-assigned this Aug 30, 2022
@aaronsteers aaronsteers added this to the v1.0 Release milestone Sep 14, 2022
@aaronsteers
Copy link
Contributor Author

@tayloramurphy - We're still having some bugs/issues related to the datetime library. I've asked @edgarrmondragon to pick this up, timeboxed to a 4 within the timeline for Tap-Toberfest.

Does that sound okay?

@tayloramurphy
Copy link
Collaborator

@aaronsteers yep - sounds good cc @edgarrmondragon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment