-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pydantic v2 import errors #45
Comments
Hi @bVdCreations, thanks for reporting this. This is indeed an issue, I'll look into the compatibility issue with Pydantic v2 more this week. |
@melvinkcx let me know if I can help. I love this project so I don't mind to contribute. I would try replacing "ErrorWrapper" with a custom type/protocol, so we loose the dependency to pydantic. I would love to hear your thoughts on this. |
Hi, to set up your dev env, you may create a virtualenv and run I plan to replace ErrorWrapper with a Protocol as well. This library is supposed to support Pydantic for payload validation, but it's completely optional. So, I'd like to make sure it works properly with or without the presence of Pydantic. I'm also intended to change the test setup to ensure both scenario are well covered. I'll probably have some time this week to work on the changes. |
hi @melvinkcx, Looking at he local handler I did not see we where using the errors to I removed them in this pull request. I'm under the impression that the payload validation happens in the dispatch function, maybe I'm missing if it is propagated in the local handler I'm not sure that was where you where headed, let me know. |
Hi @bVdCreations, I just released a new version, which includes a fix for this error. Feel free to try it out. Thanks. |
@melvinkcx thanks a lot, I could complete the migration to pydantic v2. |
When trying to upgrade to pydantic V2. there is the following import error
it does not seem there is a direct replacement for "ErrorWrapper"
https://github.com/pydantic/pydantic/blob/main/pydantic/errors.py
The text was updated successfully, but these errors were encountered: