-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a community member, I want to see old pictures so I can revisit places I know. #85
Comments
Also, there are major improvements to include this.
|
@tiagobugarin can you please review? |
@tiagobugarin you told me you have the archive of old images. can you change the code with the right file names? I left comments in the file specifying the images. |
just saw this one... can't do it now. but tomorrow... it is not that i have kept a ledge or something... i just have a process in mind to put every image i have in the right order... would need some time to collect everything and order correctly, including dates of release. |
done... |
my revirew: the code works as intended providing a selectable function and i can say the the thing is, is it ready for merge the |
yes! I build it on the last commit on the |
actually you built and merged it to the |
what I tried to say is that I build on top of the last commit on the |
Following the meeting from this afternoon (may 4th, 2020) we defined some steps to resolve this issue. First, the gathering of the historical order of the images. This task was taken by @bruquevedo who made most of it with some help from me to elucidate some technical stuff and follow some commit dates. |
Following the meeting from this afternoon (may 4th, 2020) we defined some steps to resolve this issue. Second, is to merge the archive code into the Master branch, to have it pulled into |
Ohhhh remember something, validators and browser compatibility! Went down the path to validate de code and verify compatibility as #60 mandates. Code is ok and ready to be reviewed for production. And now I think this third step gets us to finally have this issue ready to be closed. |
@tiagobugarin I just tested the archive in alpha.
Let's go to production :) |
This week we realized a problem in our approach to remind the community that there's a new picture. Since we're sending emails with the homepage (bucoli.co) link:
Since (1) it breaks the experience of the users drastically and (2) we can't roll back and fix emails already sent; I consider this a major bug that needs to be fixed before sending the next email.
The text was updated successfully, but these errors were encountered: