Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Contributions - Please provide a pre-commit or something to enforce formatting #8

Closed
jseiser opened this issue Aug 15, 2023 · 1 comment · Fixed by #16
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jseiser
Copy link
Contributor

jseiser commented Aug 15, 2023

Contact Details

justinseiser@gmail.com

What happened?

When contributing to this chart, it would be nice if you all provided some sort of pre-commit or something similar so all of our code was forced to be formatted the same way. Same with generating a readme, or providing some sort of linter_values.yaml that has to be ran etc.

Im much more familiar with Gitlab, than github, but being able to enforce these things locally, will def. make passing your Github CI easier for us when we contribute.

Example pre-commit

repos:
  - repo: https://github.com/pre-commit/pre-commit-hooks
    rev: v4.4.0
    hooks:
      # Git style
      - id: check-added-large-files
      - id: check-merge-conflict
      - id: check-vcs-permalinks
      - id: forbid-new-submodules
      - id: no-commit-to-branch

      # Common errors
      - id: end-of-file-fixer
      - id: trailing-whitespace
        args: [--markdown-linebreak-ext=md]
        exclude: CHANGELOG.md
      - id: check-merge-conflict
      - id: check-executables-have-shebangs

      # Cross platform
      - id: check-case-conflict
      - id: mixed-line-ending
        args: [--fix=lf]

      # Security
      - id: detect-private-key

  - repo: https://github.com/norwoodj/helm-docs
    rev: v1.11.0
    hooks:
      - id: helm-docs

Chart type

Standalone

Chart version

0.1.0

Environment

Local Machine

Relevant log output

No response

@antejavor
Copy link
Collaborator

Thanks for reporting this issue @jseiser, we were planning to add this, it will come in the following weeks.

@antejavor antejavor added this to the v0.1.2 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants