Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add periodic commit module #438

Open
double-di opened this issue Jan 18, 2024 · 6 comments
Open

[Feature request] Add periodic commit module #438

double-di opened this issue Jan 18, 2024 · 6 comments
Labels
community community Effort - High Effort - High feature feature Frequency - Monthly Frequency - Monthly Priority - Later Priority - Later Reach - Some Reach - Some Severity - S2 Severity - S2

Comments

@double-di
Copy link

Hi!
We are in the middle of switching from neo4j to memgraph.
We would love to see
https://neo4j.com/labs/apoc/4.1/overview/apoc.periodic/apoc.periodic.commit/
in this module, since a lot of our queries are using it.

Thanks a lot!

@karmenrabar
Copy link

Hello @double-di ! Thank you for your interest in the periodic commit module. To better understand the situation, could you provide more details on the specific use case or scenarios where this module is being considered? Do you have a workaround for the moment? Your input will help us evaluate the impact and prioritization of the periodic commit module.

@gitbuda gitbuda removed the bug bug label Jan 19, 2024
@gitbuda
Copy link
Member

gitbuda commented Jan 19, 2024

Related issue memgraph/memgraph#1182

@DavIvek DavIvek added Effort - High Effort - High and removed Effort - Unknown Effort - Unknown labels Jan 22, 2024
@hal-eisen-MG hal-eisen-MG added Priority - Later Priority - Later and removed Priority - Later Priority - Later labels Feb 4, 2024
@hal-eisen-MG hal-eisen-MG added Priority - Later Priority - Later Priority - Next Priority - Next and removed Priority - Later Priority - Later labels Feb 18, 2024
@hal-eisen-MG hal-eisen-MG added Priority - Later Priority - Later and removed Priority - Next Priority - Next labels Feb 26, 2024
@katarinasupe katarinasupe added Frequency - Monthly Frequency - Monthly Reach - Some Reach - Some and removed Importance - I3 Importance - I3 labels Feb 27, 2024
@gitbuda gitbuda removed their assignment Mar 14, 2024
@double-di
Copy link
Author

@karmenrabar Hi! Let me try to explain our usecase. Our database consist of 5B nodes & 5B relations. 100 M nodes are marked as "Starred". For any node we are trying to answer the question "Is it connected to a starred node with 16 hops or not? If it is connected - show any shortest path". Since the amount of nodes & relations is big it is not possible to answer this question in realtime by executing BFS directly. So for every "Starred" node we are precalculating (connecting with "CLOSE_TO_STARRED" relations to all the connected nodes) so we can answer this question fast. This process is very long and is implemented incrementally using flags "should_calculated_stared" on the nodes that should be calculated and apoc.periodic.commit to calculate a batch of nodes -> commit -> proceed

@antejavor antejavor added Severity - S2 Severity - S2 and removed Severity - S3 Severity - S3 labels Mar 25, 2024
@antejavor
Copy link

antejavor commented Mar 25, 2024

Hi @double-di, thanks a lot for providing an in-depth explanation of this feature request 🚀 . Based on your explanation, I gave this feature request a bit higher priority.

How is your Memgraph experience overall?

Just for info, we are hosting Office hours calls. If you need any help from the Memgraph team in your journey or provide feedback, it could be worth while to jump on a short engineering-driven call.

@double-di
Copy link
Author

double-di commented Mar 28, 2024

Thanks a lot for your support @antejavor . We are currently on early adoption stage

@katarinasupe
Copy link
Contributor

Hi @double-di, just to keep you posted - you can track progress for periodic commit on Memgraph repo, since it will be a part of Cypher. How is your project with Memgraph going? At what stage are you now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community Effort - High Effort - High feature feature Frequency - Monthly Frequency - Monthly Priority - Later Priority - Later Reach - Some Reach - Some Severity - S2 Severity - S2
Projects
Development

No branches or pull requests

7 participants