Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite rav1d-tools in safe Rust from scratch #1349

Open
kkysen opened this issue Sep 9, 2024 · 0 comments
Open

Rewrite rav1d-tools in safe Rust from scratch #1349

kkysen opened this issue Sep 9, 2024 · 0 comments
Labels
enhancement New feature or request low priority Issues that we would like to address at some point in the future refactoring Cleaning up transpiled code

Comments

@kkysen
Copy link
Collaborator

kkysen commented Sep 9, 2024

These two tools, dav1d (which we'll maybe rename to rav1d) and seek-stress, are fairly small (compared to the rest of librav1d), but they do a lot of unsafe type casting (simulating virtual classes) that is difficult to straightforwardly make safe in Rust. Also, for some of the code in these tools, there are already existing Rust libraries we can reuse, like mp4parse (see closed #16). And finally, we can use the Rust API directly here, making things much safer and eliminating the DRav1d overhead of storing duplicate dav1d types.

@kkysen kkysen added enhancement New feature or request refactoring Cleaning up transpiled code low priority Issues that we would like to address at some point in the future labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Issues that we would like to address at some point in the future refactoring Cleaning up transpiled code
Projects
None yet
Development

No branches or pull requests

1 participant