Skip to content

Commit 5e5cc76

Browse files
committed
refactor: change store logic and design
1 parent a4bb829 commit 5e5cc76

File tree

8 files changed

+246
-222
lines changed

8 files changed

+246
-222
lines changed

packages/pluggableWidgets/datagrid-web/src/Datagrid.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@
5757
<caption>Enable select all pages</caption>
5858
<description>Allow select all through multiple pages (based on current filter). Only works if total count is known.</description>
5959
</property>
60-
<property key="selectAllPagesBufferSize" type="integer" defaultValue="500">
61-
<caption>Select all buffer size</caption>
62-
<description>Batch size for processing select all operations. If total count is less than buffer size, selection is immediate.</description>
60+
<property key="selectAllPagesPageSize" type="integer" defaultValue="500">
61+
<caption>Select all page size</caption>
62+
<description>When selecting items from a large data source, items are selected in batches. This setting controls the size of the batches.</description>
6363
</property>
6464
<property key="selectingAllLabel" type="textTemplate" required="false">
6565
<caption>Selecting all label</caption>

packages/pluggableWidgets/datagrid-web/src/features/data-export/ProgressStore.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { makeAutoObservable } from "mobx";
22

33
export class ProgressStore {
4-
exporting = false;
4+
inProgress = false;
55
lengthComputable = false;
66
loaded = 0;
77
total = 0;
@@ -10,7 +10,7 @@ export class ProgressStore {
1010
}
1111

1212
onloadstart = (event: ProgressEvent): void => {
13-
this.exporting = true;
13+
this.inProgress = true;
1414
this.lengthComputable = event.lengthComputable;
1515
this.total = event.total;
1616
this.loaded = 0;
@@ -21,7 +21,7 @@ export class ProgressStore {
2121
};
2222

2323
onloadend = (): void => {
24-
this.exporting = false;
24+
this.inProgress = false;
2525
this.lengthComputable = false;
2626
this.loaded = 0;
2727
this.total = 0;

packages/pluggableWidgets/datagrid-web/src/features/multi-page-selection/SelectAllProgressStore.ts

Lines changed: 0 additions & 47 deletions
This file was deleted.
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
export * from "./selection/types.js";
2-
export * from "./selection/helpers.js";
3-
export * from "./selection/keyboard.js";
41
export {
52
getGlobalSelectionContext,
63
useCreateSelectionContextValue,
74
useSelectionContextValue
85
} from "./selection/context.js";
9-
export { MultiPageSelectionController } from "./selection/MultiPageSelectionController.js";
6+
export * from "./selection/helpers.js";
7+
export * from "./selection/keyboard.js";
108
export { SelectActionHandler } from "./selection/select-action-handler.js";
9+
export { SelectAllController } from "./selection/SelectAllController.js";
10+
export * from "./selection/types.js";

packages/shared/widget-plugin-grid/src/selection/MultiPageSelectionController.ts

Lines changed: 0 additions & 165 deletions
This file was deleted.

0 commit comments

Comments
 (0)