Skip to content

feat: CLI stdout logs are clean and readable #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #1153
vansangpfiev opened this issue Aug 28, 2024 · 3 comments
Closed
Tracked by #1153

feat: CLI stdout logs are clean and readable #1038

vansangpfiev opened this issue Aug 28, 2024 · 3 comments
Assignees
Labels
category: app shell Installer, updaters, distributions type: feature request A new feature
Milestone

Comments

@vansangpfiev
Copy link
Contributor

We are using trantor logger for cli output, it has other metadata information.

> .\cortex-cpp.exe models start tinyllama
20240828 04:13:34.427000 UTC 8240 INFO  {"message":"Model loaded successfully"} - start_model_cmd.cc:35

Should only output something like

Model tinyllama loaded successfully
@vansangpfiev vansangpfiev self-assigned this Aug 28, 2024
@imtuyethan imtuyethan moved this to Icebox in Menlo Aug 28, 2024
@imtuyethan imtuyethan added the type: feature request A new feature label Aug 28, 2024
@vansangpfiev vansangpfiev self-assigned this Aug 29, 2024
@vansangpfiev vansangpfiev moved this from Icebox to In Progress in Menlo Aug 29, 2024
@vansangpfiev vansangpfiev moved this from In Progress to In Review in Menlo Sep 4, 2024
@freelerobot
Copy link
Contributor

I think there are 2 logging modes:

  • verbose: raw log dump
  • default: nice stdout logging as you indicated

Is it possible to let users toggle btw the two. They also don't have to be mutually exclusive, i.e. verbose is a superset of both.

@freelerobot freelerobot changed the title Format cortex cli output feat: CLI logs are clean and readable Sep 6, 2024
@freelerobot freelerobot changed the title feat: CLI logs are clean and readable feat: CLI stdout logs are clean and readable Sep 6, 2024
@freelerobot freelerobot added the category: app shell Installer, updaters, distributions label Sep 6, 2024
@dan-menlo dan-menlo mentioned this issue Sep 8, 2024
6 tasks
@vansangpfiev
Copy link
Contributor Author

I think there are 2 logging modes:

  • verbose: raw log dump
  • default: nice stdout logging as you indicated

Is it possible to let users toggle btw the two. They also don't have to be mutually exclusive, i.e. verbose is a superset of both.

We added the --verbose flag for each CLI command. I'm not sure which use-case user needs to toggle between the two. Can you please elaborate more on that?

@dan-menlo dan-menlo moved this from In Review to Review + QA in Menlo Sep 29, 2024
@gabrielle-ong
Copy link
Contributor

Closed as completed

@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Menlo Oct 3, 2024
@gabrielle-ong gabrielle-ong added this to the v1.0.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: app shell Installer, updaters, distributions type: feature request A new feature
Projects
Archived in project
Development

No branches or pull requests

5 participants
@vansangpfiev @gabrielle-ong @freelerobot @imtuyethan and others