Skip to content

bug: Fail to get list model information: Unable to create model.list file #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 6 tasks
freelerobot opened this issue Sep 21, 2024 · 4 comments
Closed
2 of 6 tasks
Assignees
Labels
category: model management Model pull, yaml, model state P0: critical Mission critical type: bug Something isn't working
Milestone

Comments

@freelerobot
Copy link
Contributor

freelerobot commented Sep 21, 2024

A bit of a regression because models.list is still in progress.
I know this is WiP, but I wanted to create this issue anyway, so we remember to check it works later on.

Cortex version

v75

Describe the Bug

  • use v75 to download models
  • run models list
❯ ls
llama3.1                          llama3.1.yaml                     stable-code-instruct-3b-GGUF      stable-code-instruct-3b-GGUF.yaml

❯ cortex-nightly models list
Fail to get list model information: Unable to create model.list file: /Users/nicolezhu/cortexcpp-nightly/models/model.list
+---------+----+-------------+--------+---------+
| (Index) | ID | model alias | engine | version |
+---------+----+-------------+--------+---------+
❯ ls
Applications            Movies                  Postman Agent           cortexcpp-nightly       homebrewltd             package-lock.json
Desktop                 Music                   Public                  deleteme.js             jan                     settings.json
Documents               Pictures                Screen Studio Projects  docs                    janhq                   uploads
Downloads               Portia                  Sites                   experiments             llama.log               zk
Library                 Postman                 cortex-web              go                      mambaforge              zsh-syntax-highlighting

Steps to Reproduce

  1. Download a few models
  2. run models list
  3. Doesn't work

Screenshots / Logs

see above

What is your OS?

  • MacOS
  • Windows
  • Linux

What engine are you running?

  • cortex.llamacpp (default)
  • cortex.tensorrt-llm (Nvidia GPUs)
  • cortex.onnx (NPUs, DirectML)
@freelerobot freelerobot added the type: bug Something isn't working label Sep 21, 2024
@freelerobot freelerobot added the P0: critical Mission critical label Sep 21, 2024
@freelerobot freelerobot added the category: model management Model pull, yaml, model state label Sep 21, 2024
@freelerobot
Copy link
Contributor Author

Questions:

  • when do we create the models.list file?
  • dynamically? i.e. only when some commands are executed
  • along with the cortex installation? i.e. comes with cortexcpp folder?
  • many edge cases on this front depending on our choices.

@namchuai
Copy link
Contributor

@0xSage , this issue will be solved when this epic is finished.

@freelerobot freelerobot moved this to In Progress in Menlo Sep 23, 2024
@freelerobot
Copy link
Contributor Author

@0xSage , this issue will be solved when this epic is finished.

Noted - thank you!

@dan-menlo dan-menlo added this to the v0.1.0 milestone Sep 24, 2024
@freelerobot
Copy link
Contributor Author

fixed

@github-project-automation github-project-automation bot moved this from In Review to Completed in Menlo Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: model management Model pull, yaml, model state P0: critical Mission critical type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants