Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@vansangpfiev
Copy link
Contributor

Describe Your Changes

This pull request includes a small but important change to the error handling logic in the EngineService::DownloadEngine method. The change corrects the condition used to check for errors when creating an engine entry.

  • engine/services/engine_service.cc: Changed the condition from create_res.has_value() to create_res.has_error() to properly detect and handle errors during engine entry creation.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev merged commit da69edf into dev Feb 14, 2025
8 checks passed
@vansangpfiev vansangpfiev deleted the s/fix/wrong-log branch February 14, 2025 04:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants