This repository was archived by the owner on Jul 4, 2025. It is now read-only.
fix: remove all yml files when delete model #1980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vansangpfiev
force-pushed
the
s/fix/rm-model
branch
3 times, most recently
from
a4258e8 to
5677eb0
Compare
vansangpfiev
force-pushed
the
s/fix/rm-model
branch
from
5677eb0 to
ade2f5d
Compare
hiento09
approved these changes
Feb 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes a change to the
ModelService::DeleteModelmethod inengine/services/model_service.ccto improve the deletion process of YAML files associated with a model. The most important change is the modification of the code to remove all YAML files in the directory instead of just a single file.Improvements to file deletion:
engine/services/model_service.cc: Updated theModelService::DeleteModelmethod to iterate over the directory and remove all files with a.ymlextension, ensuring that all relevant YAML files are deleted.Fixes Issues
cortex models delete ...removes the model but not all metadata around it #1881Self Checklist