Refactor tests that use expectEmit cheatcode

[bayological]

Description

A recent update to Foundry has altered the behaviour of the expectEmit cheatcode, which is breaking our current test suite. In the past, expectEmit could be called at any point before the function that would cause the event to be emitted. However, the recent update requires that expectEmit is called immediately before the triggering function.

Our existing tests that are checking for emits now fail due to this change, in order to fix our test suite we need to update all tests to place expectEmit immediately before the respective call that triggered the event.

Acceptance Criteria

• Refactor tests to ensure that expectEmit is invoked immediately before the call that triggers the event emission
• All tests pass

[bayological]

Story Points: 2
See the discussion in Sprint Poker #​​12

Powered by Parabol