Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't swap on clicking on the "Swap" button sometimes #164

Open
Andrew718PLTS opened this issue Nov 25, 2024 · 2 comments
Open

Doesn't swap on clicking on the "Swap" button sometimes #164

Andrew718PLTS opened this issue Nov 25, 2024 · 2 comments
Labels
automation-bug bug Something isn't working

Comments

@Andrew718PLTS
Copy link

Description

Sometimes, it doesn't swap on clicking on the "Swap" button - it stops with the "'Approve already started or finished, ignoring submit'" console debug that looks like kinda too general for three different cases. I guess, it has to be investigate, divided by another IFs instead of one general if with a log and return. My case, I didn't have any reactions on the swap button clicking - no txs sent, just staying on the same state of the page.

STR

  1. Navigate the the app with the connected Metamask wallet
  2. Select any token pair that have a valid median (e.g: axlUSDC to cREAL)
  3. Click on the "Continue" button
  4. Click on the "Swap" button

Actual Result

  1. Doesn't start a swapping with opening the "Performing Swap" popup - just a console debug log
  2. Quite general if statement with a simple log and return in the end that looks like doesn't cover all cases

Expected Result

Start a swapping with opening the "Performing Swap" popup - console log is okay, but it has to be handled properly to avoid skipping some corner cases like this when we do nothing.

Attachments

Screenshot 2024-11-25 at 11.06.26.png

Private Zenhub Video

@Andrew718PLTS Andrew718PLTS added automation-bug bug Something isn't working labels Nov 25, 2024
@Andrew718PLTS
Copy link
Author

Today, this issue reproduced again, exactly with case: from axlUSDC to cREAL tokens. On reproducing try this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation-bug bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants
@Andrew718PLTS and others