Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LeagueListDto, LeaguePositionsDto does not exist in cassiopeia #26

Open
Lyie123 opened this issue Nov 19, 2020 · 3 comments
Open

LeagueListDto, LeaguePositionsDto does not exist in cassiopeia #26

Lyie123 opened this issue Nov 19, 2020 · 3 comments

Comments

@Lyie123
Copy link

Lyie123 commented Nov 19, 2020

Hi,
what are the equivalent classes in cassiopeia?
LeagueListDto, LeaguePositionsDto does not exist anymore in cassiopeia.

Greetings

@jjmaldonis
Copy link
Member

I'm not sure when you last used Cass, but the latest League classes can be found here: https://cassiopeia.readthedocs.io/en/latest/cassiopeia/league.html#leagues

Also, you may be in the wrong repository. This repo is for plugins for Cass and is not the main repo.

@Lyie123
Copy link
Author

Lyie123 commented Nov 19, 2020

Hello @jjmaldonis,
cassiopeia-sqlstore/league.py

from cassiopeia.dto.league import LeagueListDto, LeaguePositionDto, LeaguePositionsDto

cassiopeia-sqlstore/sqlstore.py

from cassiopeia.dto.league import LeagueListDto, LeaguePositionsDto, ChallengerLeagueListDto, MasterLeagueListDto, GrandmasterLeagueListDto

The problem is, that this classes (LeagueListDto, LeaguePositionsDto) not longer exists in cassiopeia.dto.league.

Sorry if I'am wrong or miss something. I'am just a beginner.

@jjmaldonis jjmaldonis reopened this Nov 26, 2020
@jjmaldonis
Copy link
Member

Ahh, the SQL plugin may be out of date. I haven't been paying any attention to it, and largely let people update it as they need it. This looks like it's going to be one of those times... I'll be honest, I'm going to let you dig into it if you want and update it. There are probably a handful of class -- mostly league related as you've found -- that need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants