Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New device Ecowitt water sensor, PN WN34D #2943

Closed
Mart124 opened this issue May 27, 2024 · 7 comments · Fixed by #2944
Closed

New device Ecowitt water sensor, PN WN34D #2943

Mart124 opened this issue May 27, 2024 · 7 comments · Fixed by #2944
Labels
device support Request for a new/improved device decoder feedback request for more information; may be closed id 30d if not received

Comments

@Mart124
Copy link

Mart124 commented May 27, 2024

Hello,

Ecowitt does a water temperature sensor, PN WN34D, user manual.

Here are then some samples from it : WN34D.zip

g001_868.34M_250k.cu8 : 20.3°C
g001_868.34M_1000k.cu8 : 25.7°C
g002_868.34M_250k.cu8 : -4.9°C
g002_868.34M_1000k.cu8 : -9.0°C

It is decoded by protocol 221, but with a 40°C offset for positive values, and another one for negative values...

Could we have a look to properly support it please ?

Thank you very much 👍

@Mart124
Copy link
Author

Mart124 commented May 27, 2024

@anthyz flagging you here, as you worked on WN34L/S in #2122 :)
@ProfBoc75 also notifying you as you worked on many devices recently :)
Thank you again, and of course, feel free if needed 👍

@ProfBoc75
Copy link
Collaborator

Hi @Mart124:

Yes, there is a gap at the data layout for the Temp.

The current decoder could be updated accordingly.

Current data layout:

TYPE 8h ID 24h NOT_USED 5h TEMP_RAW 11s  NOT_USED 1b BAT 7d CRC 8h CHECKSUM 8h TRAIL_BYTE 12h 2x

New one:

TYPE 8h ID 24h SUB_TYPE 4h TEMP_RAW 12s  NOT_USED 1b BAT 7d CRC 8h CHECKSUM 8h TRAIL_BYTE 12h 2x

If SUB_TYPE = 0   = WN34L, Current decoder, temp = (Temp_raw - 400) * 0.1f
If SUB_TYPE = 0x4 = WN34D, No Temp offset , temp = Temp_raw * 0.1f

Here the bitbench

@ProfBoc75 ProfBoc75 linked a pull request May 28, 2024 that will close this issue
@ProfBoc75 ProfBoc75 added device support Request for a new/improved device decoder feedback request for more information; may be closed id 30d if not received labels May 28, 2024
@ProfBoc75
Copy link
Collaborator

I want to confirm my assumption, can someone confirm the sub_type approach as we don't have lot of samples to replay.

@Mart124
Copy link
Author

Mart124 commented May 28, 2024

Hi @ProfBoc75

First, thank you very much for the debug, and for the PR ! Really glad :)
Also glad to see that it does not require a full new decoder, but an update only.

I want to confirm my assumption, can someone confirm the sub_type approach as we don't have lot of samples to replay.

Do you want some more samples from the WN34D variant ? Or from the WN34L / WN34S ones ?
I only have the D here...

Thank you again 👍

@ProfBoc75
Copy link
Collaborator

Hi @Mart124 :

Just try with -R 221:v and report few codes : {72}xxxx... results, please, it's enough for me.

like this: (from WN34L samples at rtl_433_tests)

{72}34003bcd021d446a09
{72}34003bcd028c44d3e1
{72}34003bcd03e84443ae
{72}34003bcd02ad44fb2a

or WN34D: (your CU8 files)

{72}340064d341014f9793
{72}340064d340cb4f955a
{72}340064d34fa64f31e0
{72}340064d34fcf4fa77f

@Mart124
Copy link
Author

Mart124 commented May 28, 2024

Here are some codes from WN34D, but without your PR (I was not able to find a compiled version from the CI, not sure it does) :

codes     : {72}340064d3411b4f172d
value : 28.3

codes     : {72}340064d340e14fa782
value : 22.5

codes     : {72}340064d340dc4f552b
value : 22

codes     : {72}340064d340d74f4f20
value : 21.5

codes     : {72}340064d340d24f3804
value : 21

codes     : {72}340064d340ce4fe2aa
value : 20.6

Hope this is what you are looking for, of course feel free if needed 👍

@ProfBoc75
Copy link
Collaborator

bitbench with your last codes, sounds good, Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
device support Request for a new/improved device decoder feedback request for more information; may be closed id 30d if not received
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants