Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding labels to metrics which we can find the owner of container with #128

Closed
sanposhiho opened this issue Oct 3, 2023 · 0 comments · Fixed by #130
Closed

adding labels to metrics which we can find the owner of container with #128

sanposhiho opened this issue Oct 3, 2023 · 0 comments · Fixed by #130
Labels
kind/feature New feature or request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@sanposhiho
Copy link
Collaborator

Currently, metrics have labels of containerName. But, it's difficult to identify the owner of those containers. Also, multiple deployments may have container with the same name, and they are mixed up in the same containerName label.
@sanposhiho sanposhiho added kind/feature New feature or request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Oct 3, 2023
@sanposhiho sanposhiho mentioned this issue Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add(metrics): add controller_name and controller_kind to metrics label mercari/tortoise
1 participant
@sanposhiho