-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Include string literal object keys as used #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that material-ui didn't come across this before, thanks for fixing it!
I finally got around to finish the testing architecture I started on some time ago, could you update the test to use it please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the test to use the fixtures instead, otherwise looks good. Thanks
String literals as object keys are currently ignored. These are used to destructure e.g. aria-* props or data-* props: