Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space between merged SDLs to fix merging errors #899

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

Igloczek
Copy link
Contributor

While using external graphs, they often (if not always) don't have any space around SDL, so while joining the strings, without adding any additional space, create unexpected keywords and throw errors while trying to parse the schema.

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?

@Igloczek
Copy link
Contributor Author

@mcollina sure thing, test added

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 369457e into mercurius-js:master Nov 2, 2022
@Igloczek Igloczek deleted the add-space-between-sdls branch November 2, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants