Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix undefined error with blank validators #404

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

sambhav
Copy link
Contributor

@sambhav sambhav commented Oct 6, 2020

Fixes #402
Fixes #403

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@2338bde). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #404   +/-   ##
=========================================
  Coverage          ?   93.80%           
=========================================
  Files             ?       73           
  Lines             ?     1662           
  Branches          ?      325           
=========================================
  Hits              ?     1559           
  Misses            ?       90           
  Partials          ?       13           
Impacted Files Coverage Δ
lib/actions/close.js 100.00% <100.00%> (ø)
lib/actions/comment.js 100.00% <100.00%> (ø)
lib/actions/labels.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2338bde...44c8250. Read the comment docs.

@sambhav
Copy link
Contributor Author

sambhav commented Oct 6, 2020

@jusx @shine2lay quick review please - mostly just docs :)

Copy link
Member

@jusx jusx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like the new example recipe you added.

@jusx
Copy link
Member

jusx commented Oct 7, 2020

@samj1912 Would you mind adding tests for scenarios with the empty validationSuite array? I'll merge it if you push the added tests to this PR.

Let me know if you want to open a separate PR for the tests. I'd be OK with that as well.

@mergeable mergeable bot merged commit d3a68f7 into mergeability:master Oct 7, 2020
@sambhav sambhav deleted the blank-validate branch October 7, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants