fix: minor bugs #508
Merged
fix: minor bugs #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
=======================================
Coverage 91.71% 91.71%
=======================================
Files 98 98
Lines 2148 2149 +1
Branches 403 404 +1
=======================================
+ Hits 1970 1971 +1
Misses 154 154
Partials 24 24
Continue to review full report at Codecov.
|
jusx
reviewed
Feb 24, 2021
| @@ -16,7 +16,7 @@ const createRequestReview = async (context, number, reviewers, actionObj) => { | |||
| action_name: actionObj.name | |||
| } | |||
|
|
|||
| actionObj.log.error(JSON.stringify(errorLog)) | |||
| actionObj.log.info(JSON.stringify(errorLog)) | |||
There was a problem hiding this comment.
What is the reasoning for this change?
There was a problem hiding this comment.
because we are using info for other known errors as well
jusx
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes following minor changes:
review_request_fail_errora loginfoinstead oferroractionObjto deleteComment functionouptutfield is not present orpull_requestis empty