-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support must_include and must_exclude regex as an array #575
feat: Support must_include and must_exclude regex as an array #575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just for symmetry sake, would you mind doing the same for must_exclude
as well? I think you also need to update the docs and changelog
Codecov Report
@@ Coverage Diff @@
## master #575 +/- ##
==========================================
+ Coverage 92.73% 92.75% +0.01%
==========================================
Files 104 104
Lines 2341 2345 +4
Branches 413 413
==========================================
+ Hits 2171 2175 +4
Misses 152 152
Partials 18 18
Continue to review full report at Codecov.
|
Alright, I tested locally and it's working great. I extended it to include |
Oh, also updated the docs for the |
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi! 👋 Another PR. This solves our use case raised in #573 and allows
must_include
to be either astring
or an `array.I imagine this would be used in other places, but I'm not sure where.