-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update node version to v20 for release and testing workflow #738
Merged
shine2lay
merged 8 commits into
mergeability:master
from
mesaugat:fix/update-ci-node-version
Mar 12, 2024
Merged
fix: update node version to v20 for release and testing workflow #738
shine2lay
merged 8 commits into
mergeability:master
from
mesaugat:fix/update-ci-node-version
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mesaugat
changed the title
fix: update node version to v20
fix: update node version to v20 for release and testing workflow
Mar 4, 2024
mesaugat
force-pushed
the
fix/update-ci-node-version
branch
from
March 11, 2024 09:15
00f4526
to
b1c848b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #738 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 110 110
Lines 2878 2878
Branches 578 578
=======================================
Hits 2674 2674
Misses 185 185
Partials 19 19 ☔ View full report in Codecov by Sentry. |
shine2lay
approved these changes
Mar 12, 2024
🎉 This PR is included in version 2.17.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ftmiro
added a commit
to ftmiro/mergeable
that referenced
this pull request
May 15, 2024
Node 20 is required to run mergeable after mergeability#738
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
actions/checkout
andactions/setup-node
probot
to version^13.0.2
as some tests were failing (especially smoke and scheduler test) in the previous versionjest
andnock
to latest versions --> nock was not mocking http requests in a few cases, don't know the exact reason but upgrading the version did work 🤷