New branch

[Sydney-o9]

Hi @merk,

I have been working on a fork of your repo here. While going through your code, I realised this bundle was awesome and that I might be able to contribute.

The changes I've made are still not documented, not tested...well still a lot to do actually.

I have just seen that you are not maintaining the bundle anymore. What should I do :( ? Should I submit a PR to merkNotificationBundle anyway (when I am ready)?
I think it would be awesome if the community could use it. What do you reckon I should do? I think your bundle has a huge potential (as every website need a notification system) and it would be great if the community could still contribute with people like you to review the changes..

Please tell me what you think would be the best option.

Note:

Some changes that are implemented (again, this is not stable and there is still a lot to do):

• use of RabbitMQBundle for queuing system
• implementation of internal notifications
• let the user choose his notification preferences (this was already largely implemented by your code through the use of filters)
• send notifications according to user roles.
• creation of a NotificationKey class. So that a user can subscribe to a particular notificationKey (for example "newsletter.of.the.week", "order.processed" etc...
• possibility to add your custom notification type through config file, for example:

    notification_types:
        email: 
            entity: Acme\NotificationBundle\Entity\EmailNotification
            renderer: merk_notification.renderer.email #service
            notification_factory: merk_notification.notification.factory.email #service
            sender_agent: merk_notification.sender.agent.email
        sms:
            entity: Acme\NotificationBundle\Entity\SMSNotification
            renderer: merk_notification.renderer.sms
            notification_factory: merk_notification.notification.factory.sms
            sender_agent: merk_notification.sender.agent.sms

        internal:
            entity: Acme\NotificationBundle\Entity\InternalNotification
            notification_factory: merk_notification.notification.factory.internal
            renderer:  merk_notification.renderer.internal
            sender_agent: merk_notification.sender.agent.internal

      #we could also implement push notifications for Android, iOS or facebook notifications etc using other bundles...

[merk]

I wont have time to maintain anything. Feel free to create your own bundle based on this code.

[Sydney-o9]

Thanks for your quick reply @merk. That's a shame you can't maintain the bundle anymore :(

So, do you want me to use a different bundle name? or keep the same bundle name?

I definitely keep @author in all files that you have created. Anything else I should do?

Just saw that you're from Australia too :)

[merk]

I dont mind, I wish I had time to maintain this but between everything else I've just never had time to continue on it.

You're free to do with it what you want, probably better to not use the same name given that it wont be my bundle anymore ;)

[Sydney-o9]

Hey @merk. Well, if you have some time one day, let me know and I'll just add you as a collaborator so that you can have push/pull access.
I'll rename the bundle so that, if it becomes bad....people won't associate it with your name :)
Anyway, I'll send you a quick note when the bundle is ready, maybe you'll have a few minutes to try it and tell me what you would change, what you don't like, etc...

See ya mate.

[merk]

Its not about that, just that its better for you to get exposure.

Thanks for picking up the torch, its definitely a bundle that needs to be developed. Will keep an eye out for it :)