Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/resize plugin #39

Merged
merged 11 commits into from
Apr 8, 2019
Merged

Feature/resize plugin #39

merged 11 commits into from
Apr 8, 2019

Conversation

janwidmer
Copy link
Contributor

Purpose of this pull request?

  • Enhancement

What changes did you make?

Added a resize plugin to subscribe for resize events

Does this pull request introduce a breaking change?

No

@jantimon
Copy link
Contributor

jantimon commented Nov 9, 2018

We should probably split WINDOW_RESIZED and COMPONENT_RESIZE

@janwidmer
Copy link
Contributor Author

Hey @jantimon please check my adjustments to separate component and window resize events. I did not resolve the merge conflict because you said I am not allowed to merge in the develop.

Copy link
Contributor

@jantimon jantimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 - could you please adjust one small thing?

packages/plugins/resize/src/index.ts Outdated Show resolved Hide resolved
@janwidmer janwidmer force-pushed the feature/resize-plugin branch from 7fec4f7 to bc8b50a Compare January 17, 2019 12:28
@janwidmer janwidmer merged commit 26df627 into master Apr 8, 2019
@ernscht ernscht deleted the feature/resize-plugin branch June 10, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants