Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct offsets over China #192

Open
xyb opened this issue Oct 16, 2020 · 7 comments
Open

Correct offsets over China #192

xyb opened this issue Oct 16, 2020 · 7 comments

Comments

@xyb
Copy link

xyb commented Oct 16, 2020

Due to national law, most online maps are intentionally distorted over China and will not match satellite images or GPS location. It would be nice if Open GPX Tracker supports “Correct offsets over China” to display the correct routes on the map.

See also:

@vincentneo
Copy link
Collaborator

firstly I need to know more about this:

is it to convert WGS-84 to GCJ-02/Baidu, maybe with something like this (https://github.com/TinyQ/TQLocationConverter)?
Also, is GCJ-02 or Baidu more preferred? Only the coordinates logged must be corrected right?

Vincent

@xyb
Copy link
Author

xyb commented Oct 17, 2020

is GCJ-02 or Baidu more preferred?

Only Baidu Maps is using bd-09 and I don't think Open GPX Tracker needs to support it.

Only the coordinates logged must be corrected right?

I think it would be best to save the coordinates as WGS-84, but offset them when displayed on a map within China, except for Apple Maps, which has already done that.

maybe with something like this (https://github.com/TinyQ/TQLocationConverter)?

Maybe. I'm not sure about the code for this repository, it seems to work.

@merlos
Copy link
Owner

merlos commented Oct 17, 2020

@xyb Thanks for pointing it out.

Would it be legal?

@xyb
Copy link
Author

xyb commented Oct 18, 2020

Would it be legal?

It's hard to say legal or not. Haven't heard of any prosecutions for translating GPS addresses, and there is a lot of discussion in the Chinese tech community about converting GPS addresses that are not banned.

@vincentneo
Copy link
Collaborator

I personally think that implementing this would be playing with fire, and would personally not be willing to take part in the implementation, considering legal ambiguity. Unsure if @merlos would share the same thoughts.

Though @xyb thanks for sharing about this offset thing in China.

@frostblazergit
Copy link

frostblazergit commented Nov 13, 2020

@vincentneo @xyb

From https://wiki.openstreetmap.org/wiki/Converting_to_WGS84

OpenStreetMap uses the WGS-84 coordinate system, as do most GPS units.

When recording in real time, there is no offset using the Apple Mapkit inside the settings, and there is an offset when Open Street Map is selected.

When viewing recorded GPX files, there is an offset when Apple Mapkit is selected, but there is no offset when Open Street Map is selected.

The GPS data is WGS-84, and Open Street Map is also WGS-84, so there is no offset when viewing the recorded GPX file.

When you select Apple Mapkit as the map of GPX file, the GPS (WGS-84) coordinates are passed in. iOS Chinese users use the local map service provider "AutoNavi Maps", so the WGS-84 coordinates are not consistent with the coordinates of "AutoNavi Maps", which causes the offset.

In the real-time logging, select Open Street Map, but the logo of "AutoNavi Maps" appears in the bottom right corner, it should be a configuration problem or an API problem in iOS system, so the offset appears.

But it's not a big deal. I can open the GPX file with GPXSee (https://github.com/tumic0/GPXSee) on my computer to check the speed and path, and it's perfect!

@papadave66
Copy link
Contributor

I use this app to record trackers, and upload it to Openstreet Map. It works well.The coordinate match exactly same.
This shift problem just cause display stuff.
The apple map doesn't have this shift display problem. It happens in other maps. Like Openstreet Map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants