Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple class diagrams are not rendered correctly #1044

Closed
tmatz opened this issue Nov 1, 2019 · 3 comments
Closed

Multiple class diagrams are not rendered correctly #1044

tmatz opened this issue Nov 1, 2019 · 3 comments
Assignees
Labels
Area: Development Retained Nonperishable Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect

Comments

@tmatz
Copy link
Contributor

tmatz commented Nov 1, 2019

Describe the bug

When there are multiple class diagrams in a same page, diagram's layout break.

To Reproduce

Following markdown code:

```mermaid
classDiagram
    Class01 <|-- Cool
```

```mermaid
classDiagram
    Class01 <|-- Cool
```

Result is this (Visual Studio Code + Markdown Preview Mermaid Support extension):

image

Expected behavior

Second diagram should be same as the first diagram.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows10
  • Browser: Visual Studio Code (1.39.2)
  • Version: Markdown Preview Mermaid Support(1.4.0 uses mermaid 8.4.0)
@tmatz tmatz added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Nov 1, 2019
@IOrlandoni
Copy link
Member

IOrlandoni commented Nov 1, 2019

I believe this is not an issue with the library but of how the extension uses it.
If you have any extra information, we'd be happy to help.

Feel free to check with them over at https://github.com/mjbvz/vscode-markdown-mermaid

@IOrlandoni IOrlandoni added Status: Pending Is not to be executed as it currently is and removed Status: Triage Needs to be verified, categorized, etc labels Nov 1, 2019
@tmatz
Copy link
Contributor Author

tmatz commented Nov 1, 2019

Unfortunately, this is bug of this library.

I already have fixed this bug in my clone repository, and confirmed the vscode extension works correctly.

I'm looking how to implement test for multiple diagram.

This bug seems have fixed once at #832, but re-introduced by #795.

@IOrlandoni
Copy link
Member

IOrlandoni commented Nov 1, 2019

@tmatz You could do an e2e test. Check the guide for some pointers . People might also be able to help out or point you in the right direction on slack.

@IOrlandoni IOrlandoni added Retained Nonperishable Status: Approved Is ready to be worked on Area: Development and removed Status: Pending Is not to be executed as it currently is labels Nov 6, 2019
@tmatz tmatz closed this as completed Nov 8, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Development Retained Nonperishable Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

No branches or pull requests

2 participants