Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent commit to develop causes demo charts to render without styles #4527

Closed
NicolasNewman opened this issue Jun 24, 2023 · 4 comments · Fixed by #4528
Closed

Recent commit to develop causes demo charts to render without styles #4527

NicolasNewman opened this issue Jun 24, 2023 · 4 comments · Fixed by #4528
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@NicolasNewman
Copy link
Collaborator

NicolasNewman commented Jun 24, 2023

Description

I recently noticed on the latest version of develop that the styles for charts on the demo page aren't loading properly. I've traced the issue back to the commit 0c449bb: handle optional .styles which is where the behavior first appears.

Steps to reproduce

Reproduce

  1. Clone the latest version of develop
  2. pnpm i && pnpm dev
  3. Navigate to the demo page
  4. Load the sequence or flowchart demo
  5. Charts aren't rendering properly

Rollback

  1. Revert to the commit before 0c449bb
  2. Restart the dev server
  3. Refresh the page
  4. The issue is resolved

Screenshots

image
image

Code Sample

No response

Setup

  • Mermaid version: develop
  • Browser and Version: [Chrome, Firefox]

Additional Context

No response

@NicolasNewman NicolasNewman added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Jun 24, 2023
@NicolasNewman
Copy link
Collaborator Author

Commit in question

@Yokozuna59
Copy link
Member

Yokozuna59 commented Jun 24, 2023

  1. Revert to the commit before 0c449bb

We can't just revert the commit; some diagrams would fail because they don't have that field since it's optional, i.e., info. I'm going to look into it shortly, when I've time.

@NicolasNewman
Copy link
Collaborator Author

I apologize if my wording was confusing. I was just describing how to identify the commit where the issue started to appear and didn't mean to imply that as the solution.

I have the lines in question commented out on my local environment so there's no immediate need on my end for having it resolved.

@Yokozuna59
Copy link
Member

It should be resolved with this PR #4528.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants