Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance benchmarking #4698

Open
sidharthv96 opened this issue Aug 3, 2023 · 1 comment
Open

Performance benchmarking #4698

sidharthv96 opened this issue Aug 3, 2023 · 1 comment
Labels
Status: Triage Needs to be verified, categorized, etc

Comments

@sidharthv96
Copy link
Member

We need to add performance benchmarks to PRs.
Does anyone have suggestions for tools which we can use?

#4697 removed parsing a diagram multiple times, but we don't know the overall impact it made on rendering. Maybe it's 10x faster, perhaps it's 1.1x faster, who knows ?!

@github-actions github-actions bot added the Status: Triage Needs to be verified, categorized, etc label Aug 3, 2023
@Yokozuna59
Copy link
Member

Vitest support it: https://vitest.dev/guide/features.html#benchmarking-experimental, which uses tinybench under the hood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc
Projects
None yet
Development

No branches or pull requests

2 participants