Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node version in CONTRIBUTING.md mismatches with .node-version #5572

Closed
exoego opened this issue Jun 15, 2024 · 0 comments · Fixed by #5573
Closed

Node version in CONTRIBUTING.md mismatches with .node-version #5572

exoego opened this issue Jun 15, 2024 · 0 comments · Fixed by #5573
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@exoego
Copy link
Contributor

exoego commented Jun 15, 2024

Description

  • 18 is mentioned in CONTRIBUTING
  • but 20 is actually used in this repo

Steps to reproduce

mermaid/packages/mermaid/src/docs/community/contributing.md

Line 55 in d6ccd93

pnpm env use --global 18

but

mermaid/.node-version

Line 1 in d6ccd93

20.12.2

Screenshots

No response

Code Sample

No response

Setup

  • Mermaid version:
  • Browser and Version: [Chrome, Edge, Firefox]

Suggested Solutions

No response

Additional Context

No response
@exoego exoego added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Jun 15, 2024
@exoego exoego mentioned this issue Jun 15, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix node version in CONTRIBUTING.md exoego/mermaid
1 participant
@exoego