Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Adapters] Config.go: lint error due to long SVG line #101

Closed
leecalcote opened this issue Jan 15, 2023 — with Slack · 3 comments
Closed

[Adapters] Config.go: lint error due to long SVG line #101

leecalcote opened this issue Jan 15, 2023 — with Slack · 3 comments
Labels
help wanted Extra attention is needed issue/willfix This issue will be worked on

Comments

Copy link
Member

Given that we’re incorporating full images (SVGs) into Meshery Adapter config.go files, we’re going to want to consider changing the lint rules to accommodate. Here is an example failure - https://github.com/meshery/meshery-cilium/pull/104/files#file-build-config-go-L29

Slack Message

Copy link

b0id commented Jan 18, 2023

@stale
Copy link

stale bot commented Mar 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Mar 4, 2023
@leecalcote leecalcote added help wanted Extra attention is needed issue/willfix This issue will be worked on labels Mar 4, 2023
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Mar 4, 2023
@leecalcote
Copy link
Member Author

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed issue/willfix This issue will be worked on
Projects
None yet
Development

No branches or pull requests

2 participants