Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for navigating to currently connected node info #837

Closed

Conversation

gabek
Copy link

@gabek gabek commented Aug 2, 2024

No pressure to accept this PR if it doesn't make sense or I'm overlooking something obvious.

Closes #836

This PR adds support for navigating to the currently connected node info screen directly from the bluetooth radio screen
by tapping on the connected radio.

It adds a small right pointing chevron after the radio is connected to show that tapping on it will navigate somewhere.

What changed?

Updated Connect.swift to support navigating to the device node info screen.

Why did it change?

To add a level of convenience to getting to your currently connected device's details.

How is this tested?

It was tested with my local node on iOS hardware.

Screenshots/Videos (when applicable)

Untitled.mp4

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have made corresponding changes to the documentation.
  • I have tested the change to ensure that it works as intended.

@CLAassistant
Copy link

CLAassistant commented Aug 2, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@72A12F4E
Copy link
Contributor

72A12F4E commented Aug 2, 2024

Wondering if we should nav to node details instead? From an IA perspective, this interaction id similar to tapping a node in the node list.

Curious what others think here.

@rcarteraz
Copy link
Member

Wondering if we should nav to node details instead? From an IA perspective, its similar to tapping a node in the node list.

Curious what others think here

I would agree with you. I like the concept here but I also think it should go to the node details page rather than directly to the device metrics.

@gabek
Copy link
Author

gabek commented Aug 2, 2024

Here's a question then, how would you feel about adding current battery, channel utilization, and airtime as values to the node details screen if that node is your currently connected node (or even for all nodes, but that's less important imho)? Then, in this case that I'm trying to optimize for, there'd be no need to navigate to device metrics at all and node details would have everything important about your current device at a glance.

@rcarteraz
Copy link
Member

Here's a question then, how would you feel about adding current battery, channel utilization, and airtime as values to the node details screen if that node is your currently connected node (or even for all nodes, but that's less important imho)? Then, in this case that I'm trying to optimize for, there'd be no need to navigate to device metrics at all and node details would have everything important about your current device at a glance.

I'm a fan of the current setup. I don't mind making it easier to get to that information with less taps, but I don't think there needs to be a redesign of how the information is currently displayed. I feel like what's currently on the node list page for the connected device is the most at-a-glance info I need.

@gabek
Copy link
Author

gabek commented Aug 2, 2024

Got it. I honestly just want to see my battery status without navigation diving :) Right now, device metrics seems to be the only way to get that information. So maybe separately there can be some brainstorming of how this value might be surfaced.

@rcarteraz
Copy link
Member

rcarteraz commented Aug 2, 2024

Got it. I honestly just want to see my battery status without navigation diving :) Right now, device metrics seems to be the only way to get that information. So maybe separately there can be some brainstorming of how this value might be surfaced.

Maybe it can be as simple as adding the battery level of the connected device there on the BLE screen?

@gabek
Copy link
Author

gabek commented Aug 2, 2024

It now navigates to Node Info.

RPReplay_Final1722637661.mp4

@gabek
Copy link
Author

gabek commented Aug 2, 2024

Maybe it can be as simple as adding the battery level of the connected device there on the BLE screen?

Love that. I'll file something separately for changing that.

@gabek gabek changed the title Add support for navigating to currently connected node metrics log Add support for navigating to currently connected node info Aug 2, 2024
@garthvh
Copy link
Member

garthvh commented Aug 7, 2024

Yeah this seems pretty confusing and not really necessary, the nav needs to be finished and then we can look at the value of some of this linking back and forth.

@garthvh garthvh closed this Aug 7, 2024
@gabek gabek deleted the gek/bluetooth_navigate_to_metrics_log branch August 7, 2024 20:37
@garthvh
Copy link
Member

garthvh commented Aug 8, 2024

The details on the new navigation structures are here, eventually it should be pretty easy to build all sorts of custom shortcuts for things like this #857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants