Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RAK4361_5005_RAK14000 board variant and enable e-Paper module #1199

Merged
merged 15 commits into from
Feb 19, 2022
Merged

Add RAK4361_5005_RAK14000 board variant and enable e-Paper module #1199

merged 15 commits into from
Feb 19, 2022

Conversation

markbirss
Copy link
Contributor

@markbirss markbirss commented Feb 11, 2022

Add new board variant

RAK 4361 5005-O base with RAK14000 e-Paper module 2.13 inch 250x122 b/w DEPG0213BNS800F41HP

RAK4361_5005_RAK14000

At first i could not get the screen to fit, fixed but now have a line down bottom of screen that i cannot seem to fix

The author of GxEPD2 wont do specific support for this e-Paper
https://forum.arduino.cc/t/good-dispay-epaper-for-arduino/419657/536

So we are stuck with using the WaveShare 213_B74 support that is similar

20220211_142941

@markbirss
Copy link
Contributor Author

Kindly review and comment

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2022

🤖 Pull request artifacts

file commit
pr1199-firmware-1.3.0.6db072e.zip 6db072e

github-actions bot added a commit that referenced this pull request Feb 13, 2022
@thebentern
Copy link
Contributor

image
I hesitate to add another target for the RAK devices, but I'm guessing the HAS_EINK is what's tripping us up here? Does that cause an exception when it can't find the display? If not and we can still use the OLED with normal operation, I'd say merge it into the normal 5005 variant defs.

@markbirss
Copy link
Contributor Author

@thebentern,

Yes HAS_EINK and SPI_INTERFACE_COUNT=2 would cause lora radio init to fail when e-Paper was not found

github-actions bot added a commit that referenced this pull request Feb 14, 2022
github-actions bot added a commit that referenced this pull request Feb 18, 2022
@thebentern
Copy link
Contributor

Mark, I want to go ahead and merge this but I think we need to tweak a couple of small things.

  1. I think we should rename the variant to RAK4361_5005_EINK, so that it doesn't further confuse the already confusing string of RAK wireless board numbers for the variant.
  2. We changed the CI build recently to use a job matrix for parallel target building. So your new target will need to be added to this collection for that to work: https://github.com/meshtastic/Meshtastic-device/blob/54f062e94d26b222fca3e3b0478e42eda03ddba2/.github/workflows/main_matrix.yml#L162

Copy link
Contributor Author

@markbirss markbirss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thebentern

Ok i have renamed it to rak4631_5005_eink

Kindly review the changes

Copy link
Contributor Author

@markbirss markbirss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated platformio.ini point to https://github.com/meshtastic/GxEPD2

@markbirss
Copy link
Contributor Author

@thebentern

I cannot edit main_matrix.yml yet

github-actions bot added a commit that referenced this pull request Feb 19, 2022
github-actions bot added a commit that referenced this pull request Feb 19, 2022
github-actions bot added a commit that referenced this pull request Feb 19, 2022
@markbirss
Copy link
Contributor Author

@thebentern

can you kindly update the CI workflow

Meshtastic-device/.github/workflows/main_matrix.yml

@geeksville
Copy link
Member

This pull request has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/rak4631-e-ink-rak14000/4366/2

@geeksville
Copy link
Member

This pull request has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/e-paper-display-rak/6269/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants