Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions #105

Open
1 of 6 tasks
Hunter275 opened this issue Aug 28, 2024 · 5 comments · May be fixed by #107
Open
1 of 6 tasks

Update GitHub Actions #105

Hunter275 opened this issue Aug 28, 2024 · 5 comments · May be fixed by #107
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed meta Issue outside of the code itself

Comments

@Hunter275
Copy link
Member

Hunter275 commented Aug 28, 2024

Update GitHub actions now that the repo is getting more attention.

This will change a lot as I learn more about GitHub Actions.
If you'd like to lend a hand please comment.

TODO:

  • Update version to match protobuf versions
  • Create an Action to update protobufs automatically and release a new version
    • BONUS: Update protobuf's Actions to fire off this Action or subscribe to protobuf releases somehow
  • Don't allow updates to .github files to update Actions and run without approval (SECURITY)
  • Ensure the version is bumped when merging to master
  • Only publish to NPM and JSR when a release is created
@Hunter275 Hunter275 added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed meta Issue outside of the code itself labels Aug 28, 2024
@Hunter275
Copy link
Member Author

Hunter275 commented Aug 28, 2024

Tool for testing workflows, going to see if I can get it working

https://github.com/nektos/act

@Hunter275
Copy link
Member Author

Update version to match protobufs version https://github.com/meshtastic/protobufs/

@Hunter275
Copy link
Member Author

Notes from @thebentern

Workflow_dispatch adds a button to "Run Workflow" and allows you to select a branch from Actions to run the workflow on.

Then use if: ${{ github.event_name == 'workflow_dispatch' }} to gate jobs

@Hunter275
Copy link
Member Author

The "version check" job needs to run when a PR is created with the target branch of master, it currently does not.

@Hunter275 Hunter275 linked a pull request Aug 29, 2024 that will close this issue
@Hunter275
Copy link
Member Author

I'm not sure if this just isn't an issue because I'm a meshtastic org member but I am able to modify the Actions and they run on the PR with the updated .yml files, thats a huge red flag to me and we need to protect ourselves on our other repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed meta Issue outside of the code itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant