cargo: Use --env-set when we have nightly rustc

Author: xclaesse

mesonbuild/backend/ninjabackend.py

@@ -2204,6 +2204,10 @@ def generate_rust_target(self, target: build.BuildTarget, target_name: str, obj_
                                      proc_macro_dylib_path,
                                      project_deps)
 
+        if any(a == '--env-set' for a in args):
+            if mesonlib.version_compare(rustc.version, '>= 1.76') and rustc.is_nightly:
+                args.extend(['-Z', 'unstable-options'])
+
         compiler_name = self.compiler_to_rule_name(rustc)
         element = NinjaBuildElement(self.all_outputs, target_name, compiler_name, main_rust_file)
         if orderdeps:

mesonbuild/cargo/interpreter.py

@@ -137,6 +137,7 @@ def _create_package(self, pkg: PackageState, build: builder.Builder, subdir: str
         ]
         ast += self._create_dependencies(pkg, build)
         ast += self._create_meson_subdir(build)
+        ast += self._create_env_args(pkg, build, subdir)
 
         if pkg.manifest.lib:
             for crate_type in pkg.manifest.lib.crate_type:
@@ -560,6 +561,53 @@ def _create_meson_subdir(self, build: builder.Builder) -> T.List[mparser.BaseNod
                       build.block([build.function('subdir', [build.string('meson')])]))
         ]
 
+    def _pkg_common_env(self, pkg: PackageState, subdir: str) -> T.Dict[str, str]:
+        # Common variables for build.rs and crates
+        # https://doc.rust-lang.org/cargo/reference/environment-variables.html
+        out_dir = os.path.join(self.environment.build_dir, subdir, f'{fixup_meson_varname(pkg.manifest.package.name)}.p')
+        os.makedirs(out_dir, exist_ok=True)
+        version_arr = pkg.manifest.package.version.split('.')
+        version_arr += ['' * (4 - len(version_arr))]
+        return {
+            'OUT_DIR': out_dir,
+            'CARGO_MANIFEST_DIR': os.path.join(self.environment.source_dir, subdir),
+            'CARGO_MANIFEST_PATH': os.path.join(self.environment.source_dir, subdir, 'Cargo.toml'),
+            'CARGO_PKG_VERSION': pkg.manifest.package.version,
+            'CARGO_PKG_VERSION_MAJOR': version_arr[0],
+            'CARGO_PKG_VERSION_MINOR': version_arr[1],
+            'CARGO_PKG_VERSION_PATCH': version_arr[2],
+            'CARGO_PKG_VERSION_PRE': version_arr[3],
+            'CARGO_PKG_AUTHORS': ','.join(pkg.manifest.package.authors),
+            'CARGO_PKG_NAME': pkg.manifest.package.name,
+            # FIXME: description can contain newlines which breaks ninja.
+            #'CARGO_PKG_DESCRIPTION': pkg.manifest.package.description or '',
+            'CARGO_PKG_HOMEPAGE': pkg.manifest.package.homepage or '',
+            'CARGO_PKG_REPOSITORY': pkg.manifest.package.repository or '',
+            'CARGO_PKG_LICENSE': pkg.manifest.package.license or '',
+            'CARGO_PKG_LICENSE_FILE': pkg.manifest.package.license_file or '',
+            'CARGO_PKG_RUST_VERSION': pkg.manifest.package.rust_version or '',
+            'CARGO_PKG_README': pkg.manifest.package.readme or '',
+        }
+
+    def _create_env_args(self, pkg: PackageState, build: builder.Builder, subdir: str) -> T.List[mparser.BaseNode]:
+        host_rustc = T.cast('RustCompiler', self.environment.coredata.compilers[MachineChoice.HOST]['rust'])
+        if not host_rustc.supports_env_set():
+            return []
+        # https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates
+        env_dict = self._pkg_common_env(pkg, subdir)
+        env_dict.update({
+            'CARGO_CRATE_NAME' : fixup_meson_varname(pkg.manifest.package.name),
+            #FIXME: TODO
+            #CARGO_BIN_NAME
+            #CARGO_BIN_EXE_<name>
+            #CARGO_PRIMARY_PACKAGE
+            #CARGO_TARGET_TMPDIR
+        })
+        env_args: T.List[mparser.BaseNode] = []
+        for k, v in env_dict.items():
+            env_args += [build.string('--env-set'), build.string(f'{k}={v}')]
+        return [build.assign(build.array(env_args), 'env_args')]
+
     def _create_lib(self, pkg: PackageState, build: builder.Builder, crate_type: raw.CRATE_TYPE) -> T.List[mparser.BaseNode]:
         dependencies: T.List[mparser.BaseNode] = []
         dependency_map: T.Dict[mparser.BaseNode, mparser.BaseNode] = {}
@@ -578,6 +626,7 @@ def _create_lib(self, pkg: PackageState, build: builder.Builder, crate_type: raw
             build.identifier('features_args'),
             build.identifier(_extra_args_varname()),
             build.identifier('system_deps_args'),
+            build.identifier('env_args'),
         ]
 
         dependencies.append(build.identifier(_extra_deps_varname()))

mesonbuild/compilers/rust.py

@@ -383,6 +383,10 @@ def get_rustdoc(self, env: 'Environment') -> T.Optional[RustdocTestCompiler]:
                                    self.is_cross, self.info, full_version=self.full_version,
                                    linker=self.linker, rustc=self)
 
+    def supports_env_set(self) -> bool:
+        return version_compare(self.version, '>= 1.76') and self.is_nightly
+
+
 class ClippyRustCompiler(RustCompiler):
 
     """Clippy is a linter that wraps Rustc.